From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 3/6] x86/smp: Clean up use of memflags in
 cpu_smpboot_alloc()
Date: Thu, 9 Apr 2015 16:07:08 +0100
Message-ID: <5526959C.2010003@citrix.com>
References: <1428427580-8854-1-git-send-email-andrew.cooper3@citrix.com>
	<1428427580-8854-4-git-send-email-andrew.cooper3@citrix.com>
	<20150409150221.GD34853@deinos.phlegethon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150409150221.GD34853@deinos.phlegethon.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 09/04/15 16:02, Tim Deegan wrote:
> At 18:26 +0100 on 07 Apr (1428431177), Andrew Cooper wrote:
>> Hoist MEMF_node(cpu_to_node(cpu)) to the start of the function, and avoid
>> passing (potentially bogus) memflags if node information is not available.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> As it happens, MEMF_node(NUMA_NO_NODE) is already == 0.

Only because of a masked overflow.  That is why (potentially) is in
brackets.

> I'm not sure if that's by design or not, but this looks robuster. :)

Indeed.

>
> Reviewed-by: Tim Deegan <tim@xen.org>

~Andrew