From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/Dom0: Don't allow dom0_max_vcpus to be zero Date: Thu, 09 Apr 2015 21:59:04 +0100 Message-ID: <5526E818.4040300@citrix.com> References: <1428611923-1282-1-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1428611923-1282-1-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky , jbeulich@suse.com, keir@xen.org Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/04/2015 21:38, Boris Ostrovsky wrote: > In case dom0_max_vcpus is incorrectly specified on boot line make sure > we will still boot. > > Signed-off-by: Boris Ostrovsky Good catch - lets not do that. Reviewed-by: Andrew Cooper > --- > xen/arch/x86/domain_build.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/arch/x86/domain_build.c b/xen/arch/x86/domain_build.c > index e5c845c..378e650 100644 > --- a/xen/arch/x86/domain_build.c > +++ b/xen/arch/x86/domain_build.c > @@ -92,6 +92,8 @@ static void __init parse_dom0_max_vcpus(const char *s) > else /* N, N-, or N-M */ > { > opt_dom0_max_vcpus_min = simple_strtoul(s, &s, 0); > + if ( opt_dom0_max_vcpus_min == 0 ) > + opt_dom0_max_vcpus_min = 1; > if ( !*s ) /* N */ > opt_dom0_max_vcpus_max = opt_dom0_max_vcpus_min; > else if ( *s++ == '-' && *s ) /* N-M */