From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kai Huang <kai.huang@linux.intel.com>
Subject: Re: [PATCH 05/10] VMX: add help functions to support PML
Date: Fri, 10 Apr 2015 15:07:12 +0800
Message-ID: <552776A0.5040802@linux.intel.com>
References: <1427423754-11841-1-git-send-email-kai.huang@linux.intel.com>
	<1427423754-11841-6-git-send-email-kai.huang@linux.intel.com>
	<20150409123138.GJ17031@deinos.phlegethon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150409123138.GJ17031@deinos.phlegethon.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>
Cc: yang.z.zhang@intel.com, andrew.cooper3@citrix.com, kevin.tian@intel.com, jbeulich@suse.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org



On 04/09/2015 08:31 PM, Tim Deegan wrote:
> At 10:35 +0800 on 27 Mar (1427452549), Kai Huang wrote:
>> +void vmx_vcpu_disable_pml(struct vcpu *v)
>> +{
>> +    ASSERT(vmx_vcpu_pml_enabled(v));
>> +
> I think this function ought to call vmx_vcpu_flush_pml_buffer() before
> disabling PML.  That way we don't need to worry about losing any
> information if a guest vcpu is reset or offlined during migration.
Good point. Thanks for catching. Will do :)

Thanks,
-Kai
>
> Cheers,
>
> Tim.