From: Ido Shamay <idos@dev.mellanox.co.il>
To: Amir Vadai <amirv@mellanox.com>, "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Yevgeny Petrilin <yevgenyp@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Achiad Shochat <achiad@mellanox.com>,
Ido Shamay <idos@mellanox.com>, Rana Shahout <ranas@mellanox.com>
Subject: Re: [PATCH net-next 01/11] net/mlx5_core: Set irq affinity hints
Date: Fri, 10 Apr 2015 11:27:26 +0300 [thread overview]
Message-ID: <5527896E.4040604@dev.mellanox.co.il> (raw)
In-Reply-To: <1428504685-8945-2-git-send-email-amirv@mellanox.com>
On 4/8/2015 5:51 PM, Amir Vadai wrote:
> From: Saeed Mahameed <saeedm@mellanox.com>
>
> + int numa_node =
> +#if IS_ENABLED(CONFIG_NUMA)
> + mdev->pdev->dev.numa_node;
> +#else
> + -1;
> +#endif
Would be nicer to use dev_to_node helper here, which already checks for
CONFIG_NUMA
include/linux/device.h:
#ifdef CONFIG_NUMA
static inline int dev_to_node(struct device *dev)
{
return dev->numa_node;
}
static inline void set_dev_node(struct device *dev, int node)
{
dev->numa_node = node;
}
#else
static inline int dev_to_node(struct device *dev)
{
return -1;
}
static inline void set_dev_node(struct device *dev, int node)
{
}
#endif
next prev parent reply other threads:[~2015-04-10 8:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 14:51 [PATCH net-next 00/11] net/mlx5: ConnectX-4 100G Ethernet driver Amir Vadai
2015-04-08 14:51 ` [PATCH net-next 01/11] net/mlx5_core: Set irq affinity hints Amir Vadai
2015-04-10 8:27 ` Ido Shamay [this message]
2015-04-12 11:15 ` Saeed Mahameed
2015-04-08 14:51 ` [PATCH net-next 02/11] net/mlx5_core: Add EQ renaming mechanism Amir Vadai
2015-04-08 14:51 ` [PATCH net-next 03/11] net/mlx5_core: Virtually extend work/completion queue buffers by one page Amir Vadai
2015-04-08 16:25 ` David Miller
2015-04-08 17:44 ` Amir Vadai
2015-04-08 14:51 ` [PATCH net-next 04/11] net/mlx5_core: HW data structs/types definitions preparation for mlx5 ehternet driver Amir Vadai
2015-04-08 16:46 ` Joe Perches
2015-04-12 15:54 ` Amir Vadai
2015-04-08 14:51 ` [PATCH net-next 05/11] net/mlx5_core/ib: New device capabilities handling Amir Vadai
2015-04-08 14:51 ` [PATCH net-next 06/11] net/mlx5_core: Implement get and set functions of ptys register fields Amir Vadai
2015-04-08 14:51 ` [PATCH net-next 07/11] net/mlx5_core: Implement get/set port status Amir Vadai
2015-04-08 18:26 ` Sergei Shtylyov
2015-04-08 18:38 ` Amir Vadai
2015-04-08 14:51 ` [PATCH net-next 08/11] net/mlx5_core: Modify CQ moderation parameters Amir Vadai
2015-04-08 14:51 ` [PATCH net-next 09/11] net/mlx5: Ethernet Datapath files Amir Vadai
2015-04-09 2:01 ` Alexander Duyck
2015-04-12 11:33 ` Saeed Mahameed
2015-04-12 11:52 ` Ido Shamay
2015-04-08 14:51 ` [PATCH net-next 10/11] net/mlx5: Ethernet resources handling Amir Vadai
2015-04-08 14:51 ` [PATCH net-next 11/11] net/mlx5: Ethernet driver Amir Vadai
2015-04-08 15:57 ` Eric Dumazet
2015-04-09 2:07 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5527896E.4040604@dev.mellanox.co.il \
--to=idos@dev.mellanox.co.il \
--cc=achiad@mellanox.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=idos@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=ranas@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.