All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org, g.liakhovetski@gmx.de,
	laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v4 1/4] v4l: of: Remove the head field in struct v4l2_of_endpoint
Date: Fri, 10 Apr 2015 11:47:20 +0200	[thread overview]
Message-ID: <55279C28.5080900@samsung.com> (raw)
In-Reply-To: <1428614706-8367-2-git-send-email-sakari.ailus@iki.fi>

Hi Sakari,

On 09/04/15 23:25, Sakari Ailus wrote:
> The field is unused. Remove it.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
> ---
>  include/media/v4l2-of.h |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/media/v4l2-of.h b/include/media/v4l2-of.h
> index f831c9c..f66b92c 100644
> --- a/include/media/v4l2-of.h
> +++ b/include/media/v4l2-of.h
> @@ -57,7 +57,6 @@ struct v4l2_of_bus_parallel {
>   * @base: struct of_endpoint containing port, id, and local of_node
>   * @bus_type: bus type
>   * @bus: bus configuration data structure
> - * @head: list head for this structure
>   */
>  struct v4l2_of_endpoint {
>  	struct of_endpoint base;
> @@ -66,7 +65,6 @@ struct v4l2_of_endpoint {
>  		struct v4l2_of_bus_parallel parallel;
>  		struct v4l2_of_bus_mipi_csi2 mipi_csi2;
>  	} bus;
> -	struct list_head head;
>  };

I don't remember what this list_head was originally intended for,
probably for some code in soc_camera on which didn't the works were
postponed or abandoned. Presumably now such code would likely live
in drivers/of/base.c anyway.

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

-- 
Regards,
Sylwester

  reply	other threads:[~2015-04-10  9:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 21:25 [PATCH v4 0/4] Add link-frequencies to struct v4l2_of_endpoint Sakari Ailus
2015-04-09 21:25 ` [PATCH v4 1/4] v4l: of: Remove the head field in " Sakari Ailus
2015-04-10  9:47   ` Sylwester Nawrocki [this message]
2015-04-10 22:40     ` Sakari Ailus
2015-04-09 21:25 ` [PATCH v4 2/4] v4l: of: Instead of zeroing bus_type and bus field separately, unify this Sakari Ailus
2015-04-10  9:50   ` Sylwester Nawrocki
2015-04-10 22:16   ` Lad, Prabhakar
2015-04-09 21:25 ` [PATCH v4 3/4] v4l: of: Parse variable length properties --- link-frequencies Sakari Ailus
2015-04-10  9:50   ` Sylwester Nawrocki
2015-04-10 22:15   ` Lad, Prabhakar
2015-04-09 21:25 ` [PATCH v4 4/4] smiapp: Use v4l2_of_alloc_parse_endpoint() Sakari Ailus
2015-04-10  9:52   ` Sylwester Nawrocki
2015-04-10 21:54   ` Lad, Prabhakar
2015-04-10 22:10     ` Sakari Ailus
2015-04-10 22:16     ` [PATCH v4.1 " Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55279C28.5080900@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.