All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, xen-devel@lists.xen.org
Cc: stefano.stabellini@citrix.com, julien.grall@linaro.org,
	tim@xen.org, ian.campbell@citrix.com,
	Zoltan Kiss <zoltan.kiss@huawei.com>
Subject: Re: [PATCH v1 0/1] xen/arm: GICv2 GICH_MISR Read-Only
Date: Fri, 10 Apr 2015 11:51:45 +0100	[thread overview]
Message-ID: <5527AB41.8000908@citrix.com> (raw)
In-Reply-To: <1428646870-22093-1-git-send-email-edgar.iglesias@gmail.com>

On 10/04/15 07:21, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> 
> Hi,

Hi Edgar,

> Does any one know why we are writing to GICH_MISR? It is a Read-Only
> register in GICv2. This showed up as illegal accesses in my QEMU logs.

I think this is a misunderstanding of the spec at the time the GIC
driver has been written. On real hardware the write access is ignored.

AFAICT, we don't even care to get a maintenance interrupt when one LR is
asserting an EOI (assuming we think this bit was enabling the assertion).

> I suspect gic-hip04 needs a similar patch. Are there any specs for
> that GIC somewhere?

This hardware is very similar to the GIC. A chinese spec has been sent
on the ML a couple of months ago [1].

Although, the HIP 04 driver is not functional anymore as the maintainers
 of this driver (from Huawei and in CC) didn't answer to previous change
to the common GIC code [2].

Regards,

[1] https://github.com/hisilicon/boards/tree/master/D01/docs

[2]
http://lists.xenproject.org/archives/html/xen-devel/2015-03/msg03835.html

-- 
Julien Grall

      parent reply	other threads:[~2015-04-10 10:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10  6:21 [PATCH v1 0/1] xen/arm: GICv2 GICH_MISR Read-Only Edgar E. Iglesias
2015-04-10  6:21 ` [PATCH v1 1/1] xen/arm: Don't write to GICH_MISR Edgar E. Iglesias
2015-04-10 10:52   ` Julien Grall
2015-04-15 15:07     ` Ian Campbell
2015-04-10 10:51 ` Julien Grall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5527AB41.8000908@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=ian.campbell@citrix.com \
    --cc=julien.grall@linaro.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    --cc=zoltan.kiss@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.