From: Preeti U Murthy <preeti-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
anton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org,
svaidy-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org,
paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bharata-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org
Subject: Re: [PATCH] cpusets: Make cpus_allowed and mems_allowed masks hotplug invariant
Date: Fri, 10 Apr 2015 19:44:02 +0530 [thread overview]
Message-ID: <5527DAAA.7030308@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150409211349.GA28729-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
Hi Serge,
On 04/10/2015 02:43 AM, Serge E. Hallyn wrote:
> On Mon, Apr 06, 2015 at 01:47:35PM -0400, Tejun Heo wrote:
>> Hello, Preeti.
>>
>> On Thu, Apr 02, 2015 at 12:26:32PM +0530, Preeti U Murthy wrote:
>>> By ensuring that the user configured cpusets are untouched, I don't see
>>> how we affect userspace adversely. The expectation usually is that the
>>> kernel keeps track of the user configurations. If anything we would be
>>> fixing an undesired behavior, wouldn't we?
>>
>> The problem is not really about which behavior is "righter" but rather
>> it's fairly likely that there are users / tools out there expecting
>> the current behavior and they wouldn't be too happy to see the
>> behavior flipping underneath them.
>>
>> One way forward would be implementing a knob in cpuset which makes it
>> switch sbetween the old and new behaviors in the legacy hierarchy.
>> It's yucky but doable if absoluately necessary, but what's the reason
>> for you not being able to transition to the unified hierarchy (except
>
> If the userspace is entirely new then this should work. The
> unified hierarchy's behavior is not backward-compatible so any old
> software which tried to create cgroups (libcgroup, lxc, etc) will
> not work with it (since it won't, for instance, know to fill in
> the enabled controllers in every newly created cgroup).
>
> Preeti, can you confirm that you don't have any need to run any
> legacy programs which use cgroups? Long as that's the case, new
I don't think I can vouch for this safely. I have posted out a V2 of
this patch adhering to Tejun's first suggestion. IMO that seemed like
a better option.
Regards
Preeti U Murthy
WARNING: multiple messages have this Message-ID (diff)
From: Preeti U Murthy <preeti@linux.vnet.ibm.com>
To: "Serge E. Hallyn" <serge@hallyn.com>, Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
lizefan@huawei.com, anton@samba.org, svaidy@linux.vnet.ibm.com,
rjw@rjwysocki.net, paulmck@linux.vnet.ibm.com, mingo@kernel.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
bharata@linux.vnet.ibm.com
Subject: Re: [PATCH] cpusets: Make cpus_allowed and mems_allowed masks hotplug invariant
Date: Fri, 10 Apr 2015 19:44:02 +0530 [thread overview]
Message-ID: <5527DAAA.7030308@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150409211349.GA28729@mail.hallyn.com>
Hi Serge,
On 04/10/2015 02:43 AM, Serge E. Hallyn wrote:
> On Mon, Apr 06, 2015 at 01:47:35PM -0400, Tejun Heo wrote:
>> Hello, Preeti.
>>
>> On Thu, Apr 02, 2015 at 12:26:32PM +0530, Preeti U Murthy wrote:
>>> By ensuring that the user configured cpusets are untouched, I don't see
>>> how we affect userspace adversely. The expectation usually is that the
>>> kernel keeps track of the user configurations. If anything we would be
>>> fixing an undesired behavior, wouldn't we?
>>
>> The problem is not really about which behavior is "righter" but rather
>> it's fairly likely that there are users / tools out there expecting
>> the current behavior and they wouldn't be too happy to see the
>> behavior flipping underneath them.
>>
>> One way forward would be implementing a knob in cpuset which makes it
>> switch sbetween the old and new behaviors in the legacy hierarchy.
>> It's yucky but doable if absoluately necessary, but what's the reason
>> for you not being able to transition to the unified hierarchy (except
>
> If the userspace is entirely new then this should work. The
> unified hierarchy's behavior is not backward-compatible so any old
> software which tried to create cgroups (libcgroup, lxc, etc) will
> not work with it (since it won't, for instance, know to fill in
> the enabled controllers in every newly created cgroup).
>
> Preeti, can you confirm that you don't have any need to run any
> legacy programs which use cgroups? Long as that's the case, new
I don't think I can vouch for this safely. I have posted out a V2 of
this patch adhering to Tejun's first suggestion. IMO that seemed like
a better option.
Regards
Preeti U Murthy
next prev parent reply other threads:[~2015-04-10 14:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 7:07 [PATCH] cpusets: Make cpus_allowed and mems_allowed masks hotplug invariant Preeti U Murthy
2014-10-08 7:07 ` Preeti U Murthy
[not found] ` <20141008070739.1170.33313.stgit-KrPcdFQQmm2yUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2014-10-08 8:07 ` Peter Zijlstra
2014-10-08 8:07 ` Peter Zijlstra
2014-10-08 9:37 ` Preeti U Murthy
2014-10-08 10:18 ` Peter Zijlstra
[not found] ` <20141008101828.GG10832-IIpfhp3q70z/8w/KjCw3T+5/BudmfyzbbVWyRVo5IupeoWH0uzbU5w@public.gmane.org>
2014-10-09 8:20 ` Preeti U Murthy
2014-10-09 8:20 ` Preeti U Murthy
[not found] ` <54364564.3090305-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2014-10-09 8:30 ` Peter Zijlstra
2014-10-09 8:30 ` Peter Zijlstra
2014-10-09 8:32 ` Peter Zijlstra
2014-10-09 8:32 ` Peter Zijlstra
2014-10-09 13:06 ` Tejun Heo
2014-10-09 13:06 ` Tejun Heo
[not found] ` <20141009130611.GA14387-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-10-09 13:47 ` Peter Zijlstra
2014-10-09 13:47 ` Peter Zijlstra
[not found] ` <20141009134758.GU10832-IIpfhp3q70z/8w/KjCw3T+5/BudmfyzbbVWyRVo5IupeoWH0uzbU5w@public.gmane.org>
2014-10-09 13:59 ` Tejun Heo
2014-10-09 13:59 ` Tejun Heo
2015-04-02 6:56 ` Preeti U Murthy
2015-04-02 6:56 ` Preeti U Murthy
[not found] ` <551CE820.9090900-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2015-04-06 17:47 ` Tejun Heo
2015-04-06 17:47 ` Tejun Heo
[not found] ` <20150406174735.GG10582-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-04-09 21:13 ` Serge E. Hallyn
2015-04-09 21:13 ` Serge E. Hallyn
[not found] ` <20150409211349.GA28729-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2015-04-10 14:14 ` Preeti U Murthy [this message]
2015-04-10 14:14 ` Preeti U Murthy
-- strict thread matches above, loose matches on Subject: below --
2014-10-08 14:54 Raghavendra KT
[not found] ` <CAC4Lta2AS6M5upg8n9Qu5+1pqCMF3j8_cYuLAS1DH9C_BQP0PA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-09 5:12 ` Preeti U Murthy
2014-10-09 5:12 ` Preeti U Murthy
[not found] ` <54361922.8070808-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2014-10-09 9:42 ` Raghavendra K T
2014-10-09 9:42 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5527DAAA.7030308@linux.vnet.ibm.com \
--to=preeti-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=anton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=bharata-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org \
--cc=svaidy-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.