All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] configure: improve multiarch support for pkgconfig
Date: Fri, 10 Apr 2015 10:15:36 -0400	[thread overview]
Message-ID: <5527DB08.8020502@redhat.com> (raw)
In-Reply-To: <1428674350.29519.3.camel@nilsson.home.kraxel.org>



On 04/10/2015 09:59 AM, Gerd Hoffmann wrote:
>    Hi,
>
>> 32-bit compilation on 64-bit hosts is broken because pkgconfig isn't
>> multi-arch aware and selects the 64-bit glibconfig.h header file.  That
>> file assumes the LP64 data model so guint64 is defined as unsigned long.
>> This does not work for 32-bit builds where sizeof(unsigned long) == 4
>> bytes.
>
> ... there are more effects, like stuff being enabled because 64bit devel
> lib is installed even when the 32bit devel lib isn't.
>
> IMO it is fine to expect users set PKG_CONFIG_LIBDIR accordingly in that
> case.  It would be very nice though to record this variable (in
> config.status maybe?) so it doesn't get lost in case make figures it
> should re-run configure because it was changed.
>

I'm not sure I follow you. What would be wrong with configure re-polling 
for the correct setting in that case?

Unless, perhaps, you are discussing the possibility of losing a user 
override from the first time they ran configure with PKG_CONFIG_LIBDIR 
already set to some custom value.

> cheers,
>    Gerd
>
>

  reply	other threads:[~2015-04-10 14:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 21:36 [Qemu-devel] [PATCH] configure: improve multiarch support for pkgconfig John Snow
2015-04-10 12:06 ` Paolo Bonzini
2015-04-10 12:21 ` Stefan Hajnoczi
2015-04-10 12:55   ` Peter Maydell
2015-04-10 14:06     ` John Snow
2015-04-10 13:59   ` Gerd Hoffmann
2015-04-10 14:15     ` John Snow [this message]
2015-04-10 14:24       ` Gerd Hoffmann
2015-04-10 12:24 ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5527DB08.8020502@redhat.com \
    --to=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.