From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCHv2 1/6] x86/hvm: don't include asm/spinlock.h
Date: Fri, 10 Apr 2015 16:24:59 +0100
Message-ID: <5527EB4B.6050309@citrix.com>
References: <1428675597-28465-1-git-send-email-david.vrabel@citrix.com>
	<1428675597-28465-2-git-send-email-david.vrabel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1Ygaom-0005Km-LZ
	for xen-devel@lists.xenproject.org; Fri, 10 Apr 2015 15:26:04 +0000
In-Reply-To: <1428675597-28465-2-git-send-email-david.vrabel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>, xen-devel@lists.xenproject.org
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Jan Beulich <jbeulich@suse.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 10/04/15 15:19, David Vrabel wrote:
> asm/spinlock.h should not be included directly.
>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>

s/asm/xen/g instead of a straight delete?

Otherwise you are relying on pulling in xen/spinlock.h implicitly.

~Andrew

> ---
>  xen/arch/x86/hvm/hvm.c     |    1 -
>  xen/arch/x86/hvm/svm/svm.c |    1 -
>  xen/arch/x86/hvm/vmx/vmx.c |    1 -
>  3 files changed, 3 deletions(-)
>
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index 4734d71..6937857 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -52,7 +52,6 @@
>  #include <asm/xstate.h>
>  #include <asm/traps.h>
>  #include <asm/mc146818rtc.h>
> -#include <asm/spinlock.h>
>  #include <asm/mce.h>
>  #include <asm/hvm/hvm.h>
>  #include <asm/hvm/vpt.h>
> diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
> index b6e77cd..6734fb6 100644
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -41,7 +41,6 @@
>  #include <asm/msr.h>
>  #include <asm/i387.h>
>  #include <asm/iocap.h>
> -#include <asm/spinlock.h>
>  #include <asm/hvm/emulate.h>
>  #include <asm/hvm/hvm.h>
>  #include <asm/hvm/support.h>
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index e1c55ce..2a0610b 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -35,7 +35,6 @@
>  #include <asm/types.h>
>  #include <asm/debugreg.h>
>  #include <asm/msr.h>
> -#include <asm/spinlock.h>
>  #include <asm/paging.h>
>  #include <asm/p2m.h>
>  #include <asm/mem_sharing.h>