From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ronny Hegewald <ronny.hegewald@online.de>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] resolve collision of generic ATA_FLAG_LOWTAG and driver specific flag
Date: Fri, 10 Apr 2015 20:02:11 +0300 [thread overview]
Message-ID: <55280213.9000601@cogentembedded.com> (raw)
In-Reply-To: <201504092009.08703.ronny.hegewald@online.de>
Hello.
On 04/09/2015 11:09 PM, Ronny Hegewald wrote:
> The patch "libata: allow sata_sil24 to opt-out of tag ordered submission"
> (72dd299d5039a336493993dcc63413cf31d0e662) introduces a regression with the
> sata_sil24 driver.
> The new flag ATA_FLAG_LOWTAG accidentially uses the same bit as
Accidentally.
> SIL24_FLAG_PCIX_IRQ_WOC in the driver. This activates code for Silicon Image
> 3132, which is only suppossed to run under 3124.
Supposed.
> ATA_FLAG_LOWTAG is only used in sata_sil24 and is planned to be removed soon,
> so lets just use another bit for the flag in sata_sil24.
Actually, ATA_FLAG_LOWTAG has been removed in the 'for-next' branch, so
this patch is no longer needed. Moreover, the newly assigned flag clashes with
the new ATA_FLAG_SATA_PORT.
> Signed-off-by: Ronny Hegewald <Ronny.Hegewald@online.de>
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-04-10 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 20:09 [PATCH] resolve collision of generic ATA_FLAG_LOWTAG and driver specific flag Ronny Hegewald
2015-04-10 11:15 ` Christoph Hellwig
2015-04-10 16:55 ` Sergei Shtylyov
2015-04-13 15:29 ` Tejun Heo
2015-04-10 17:02 ` Sergei Shtylyov [this message]
2015-04-15 22:56 ` Ronny Hegewald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55280213.9000601@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-ide@vger.kernel.org \
--cc=ronny.hegewald@online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.