[Buildroot] [PATCH 2/2] infra/pkg-kconfig: require an non-empty KCONFIG_FILE

[Arnout Vandecappelle <arnout@mind.be>]

On 10/04/15 22:40, Yann E. MORIN wrote:
> Arnout, All,
> 
> On 2015-04-10 22:01 +0200, Arnout Vandecappelle spake thusly:
>> On 08/04/15 22:49, Yann E. MORIN wrote:
>> [snip]
>>> So, because neither "use defconfig" nor "use custom config" is set,
>>> KERNEL_SOURCE_CONFIG is not set, so LINUX_KCONFIG_FILE ends up empty.
>>
>>
>> BR2_LINUX_KERNEL_USE_DEFCONFIG and BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG are the
>> only two possibilities in the "Kernel configuration" choice, so one of them will
>> always be set.
> 
> No, neither would be set if you don't enable building a kernel. In that
> case, LINUX_KCONFIG_FILE is empty, but the $(eval $(kconfig-package)) is
> still called, and thus the test should fail. But it does not.

 Argh, stupid me... The documentation I pointed to explicitly says a few lines
lower:

Note that ifdef only tests whether a variable has a value. It does not expand
the variable to see if that value is nonempty.


 Therefore, I've un-rejected this patch, and I'm adding my

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

> 
>>> However, our ifndef did not trigger so far.
>>
>>  The kernel isn't built in the autobuilders, so where would it trigger?
> 
> Well, obviously, locally. ;-)
> 
> Regards,
> Yann E. MORIN.
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F