From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yggxa-0007Ik-QX for qemu-devel@nongnu.org; Fri, 10 Apr 2015 17:59:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YggxV-0000le-Lw for qemu-devel@nongnu.org; Fri, 10 Apr 2015 17:59:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38159 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YggxV-0000lD-8o for qemu-devel@nongnu.org; Fri, 10 Apr 2015 17:59:29 -0400 Message-ID: <552847BB.4040608@suse.de> Date: Fri, 10 Apr 2015 23:59:23 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <55153546.5060906@hotmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 02/12 v9] linux-user: tilegx: Add target features support within qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Riku Voipio , qemu-devel , Chris Metcalf , "walt@tilera.com" , Chen Gang , "rth@twiddle.net" Am 10.04.2015 um 23:51 schrieb Peter Maydell: > On 10 April 2015 at 21:41, Chen Gang wrot= e: >> On 4/10/15 05:31, Peter Maydell wrote: >>> On 27 March 2015 at 10:49, Chen Gang wr= ote: >>>> +typedef struct target_sigaltstack { >>>> + abi_ulong ss_sp; >>>> + abi_ulong ss_size; >>>> + abi_long ss_flags; >>>> +} target_stack_t; >>> >>> Where does this come from? It doesn't match the kernel's >>> generic-headers struct layout. >>> >> >> Oh, sorry, originally, I guess, I only copied it from microblaze, did >> not check kernel. >=20 > These structures are all user-guest-facing ABI, so they must > match the kernel's structures for your target architecture. >=20 >> I shall use generic-headers which tilegx will use (the result will lik= e >> alpha has done): >> >> typedef struct target_sigaltstack { >> abi_ulong ss_sp; >> int32_t ss_flags; >> int32_t dummy; >> abi_ulong ss_size; >> } target_stack_t; >=20 > This doesn't match the kernel either. >=20 > http://lxr.free-electrons.com/source/include/uapi/asm-generic/signal.h#= L111 >=20 > You have a pointer, an int and a size_t, so you want > abi_ulong ss_sp; > abi_int ss_flags; > abi_ulong ss_size; >=20 > like aarch64. I know linux-user is a mess. But that does not sound appealing. If this is from a generic header, can't we put that in a shared header too and #include it from aarch64 and tilegx without duplicating it? Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)