From: Alexei Starovoitov <ast@plumgrid.com>
To: Cong Wang <cwang@twopensource.com>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: David Miller <davem@davemloft.net>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Eric Dumazet <edumazet@google.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: use jump label patching for ingress qdisc in __netif_receive_skb_core
Date: Fri, 10 Apr 2015 18:41:17 -0700 [thread overview]
Message-ID: <55287BBD.2030006@plumgrid.com> (raw)
In-Reply-To: <CAHA+R7PXy_kOn3pUOdGvU4L3n-EgH8cXNCmGQfaDQTUNaP2S4w@mail.gmail.com>
On 4/10/15 6:14 PM, Cong Wang wrote:
> So the following code is slow enough to deserve a static key
> optimization?
>
> struct netdev_queue *rxq = rcu_dereference(skb->dev->ingress_queue);
>
> if (!rxq || rcu_access_pointer(rxq->qdisc) == &noop_qdisc)
> goto out;
It helps a little bit here and helps even more to my ingress_l2 patch
that is based on top of this one. Every cycle counts.
next prev parent reply other threads:[~2015-04-11 1:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 21:07 [PATCH net-next] net: use jump label patching for ingress qdisc in __netif_receive_skb_core Daniel Borkmann
2015-04-10 22:30 ` Eric Dumazet
2015-04-10 22:34 ` Daniel Borkmann
2015-04-10 22:40 ` Alexei Starovoitov
2015-04-11 1:14 ` Cong Wang
2015-04-11 1:41 ` Alexei Starovoitov [this message]
2015-04-11 15:40 ` Alexei Starovoitov
2015-04-13 17:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55287BBD.2030006@plumgrid.com \
--to=ast@plumgrid.com \
--cc=cwang@twopensource.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.