All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: fix arch/arm/Makefile for Tegra
Date: Sat, 11 Apr 2015 17:39:20 +0200	[thread overview]
Message-ID: <55294028.2010100@web.de> (raw)
In-Reply-To: <1428762568-32088-1-git-send-email-yamada.masahiro@socionext.com>

On 2015-04-11 16:29, Masahiro Yamada wrote:
> Since commit 79d75d752717 (ARM: move -march=* and -mtune= options to
> arch/arm/Makefile), all the Tegra boards are broken because the SPL
> is built for ARMv7.
> 
> Insert Tegra-specific code to arch/arm/Makefile to set compiler
> flags for an earlier ARM architecture.
> 
> Note:
> The patch for commit 79d75d752717 *was* correct when it was posted.
> Notice it was written for multi .config configuration where Kconfig
> set CONFIG_CPU_V7/CONFIG_CPU_ARM720T for Tegra U-Boot Main/SPL,
> respectively.  But, it look long until that patch was merged into
> the mainline, and finally, it was overtaken by commit e02ee2548afe
> (kconfig: switch to single .config configuration).
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Reported-by: Stephen Warren <swarren@nvidia.com>
> Reported-by: Jan Kiszka <jan.kiszka@web.de>
> ---
> 
> I just did build test for all the Tegra boards.
> 
> Stephen,
> Could you do run-test?
> 
> Tom,
> Please hold back the v2015.04 release until we confim
> this problem is fixed.
> 
> 
>  arch/arm/Makefile | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 6463c19..bd4749c 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -2,6 +2,11 @@
>  # SPDX-License-Identifier:	GPL-2.0+
>  #
>  
> +ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_TEGRA),yy)
> +CONFIG_CPU_V7=
> +CONFIG_CPU_ARM720T=y
> +endif
> +
>  # This selects which instruction set is used.
>  arch-$(CONFIG_CPU_ARM720T)	=-march=armv4
>  arch-$(CONFIG_CPU_ARM920T)	=-march=armv4
> 

Tested-by: Jan Kiszka <jan.kiszka@siemens.com>

Thanks for the quick solution!
Jan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150411/36c82a7f/attachment.sig>

      reply	other threads:[~2015-04-11 15:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-11 14:29 [U-Boot] [PATCH] ARM: fix arch/arm/Makefile for Tegra Masahiro Yamada
2015-04-11 15:39 ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55294028.2010100@web.de \
    --to=jan.kiszka@web.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.