From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50874)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Yh3Es-0002t8-4n
	for qemu-devel@nongnu.org; Sat, 11 Apr 2015 17:46:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Yh3Eo-0006p5-3U
	for qemu-devel@nongnu.org; Sat, 11 Apr 2015 17:46:54 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43334 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Yh3En-0006ot-TD
	for qemu-devel@nongnu.org; Sat, 11 Apr 2015 17:46:50 -0400
Message-ID: <55299647.10303@suse.de>
Date: Sat, 11 Apr 2015 23:46:47 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1428777292-24628-1-git-send-email-afaerber@suse.de>
	<1428777292-24628-8-git-send-email-afaerber@suse.de>
	<CAFEAcA_=rO28c8n4iVXnKVd7qfun_RwvqtNW7P8Uu2tmfkxfTg@mail.gmail.com>
	<552983D8.70904@suse.de>
	<CAFEAcA-0zbMarz23RH_AMoOq+8nk4w7tCNoJfp9spC5H=+k__g@mail.gmail.com>
In-Reply-To: <CAFEAcA-0zbMarz23RH_AMoOq+8nk4w7tCNoJfp9spC5H=+k__g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test
	by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>

Am 11.04.2015 um 23:33 schrieb Peter Maydell:
> On 11 April 2015 at 21:28, Andreas F=C3=A4rber <afaerber@suse.de> wrote=
:
>> Are you sure that QEMU / runcom / pi_10.com still try to map to that
>> address zero?
>=20
> It's the first thing runcom.c's main() does after checking you've
> passed it enough command line arguments.

This?

    vm86_mem =3D mmap((void *)0x00000000, 0x110000,
                    PROT_WRITE | PROT_READ | PROT_EXEC,
                    MAP_FIXED | MAP_ANON | MAP_PRIVATE, -1, 0);
    if (vm86_mem =3D=3D MAP_FAILED) {
        perror("mmap");
        exit(1);
    }

For whatever reason it does not take the MAP_FAILED path here...

But I can certainly live with dropping this patch, it's the last for a
reason. :)

Andreas

--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG N=C3=BCrnberg)