From: Guenter Roeck <linux@roeck-us.net>
To: Jeff Epler <jepler@unpythonic.net>
Cc: Richard Weinberger <richard@nod.at>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xtensa: Fix execdomain removal
Date: Sun, 12 Apr 2015 08:00:47 -0700 [thread overview]
Message-ID: <552A889F.6050307@roeck-us.net> (raw)
In-Reply-To: <20150412144346.GD7215@unpythonic.net>
On 04/12/2015 07:43 AM, Jeff Epler wrote:
> On Sat, Apr 11, 2015 at 07:19:51PM -0700, Guenter Roeck wrote:
>> The removal of exexdomain changes pointer offsets into the thread_info
>> structure.
> ...
>> -#define TI_EXEC_DOMAIN 0x00000004
>> -#define TI_FLAGS 0x00000008
>> +#define TI_FLAGS 0x00000004
>
> Hmm. If these have to be maintained by hand, perhaps they can be
> BUILD_BUG_ON'd in some appropriate C file? e.g.,
>
> BUILD_BUG_ON(TI_FLAGS != offsetof(struct thread_info, flags));
>
> Jeff
>
Other architectures use either DEFINE or OFFSET macros to define
those flags, so that would probably be a better solution if something
more fancy is asked for. That should probably be a separate patch,
though.
Guenter
next prev parent reply other threads:[~2015-04-12 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 2:19 [PATCH] xtensa: Fix execdomain removal Guenter Roeck
2015-04-12 14:43 ` Jeff Epler
2015-04-12 15:00 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-04-12 14:58 Richard Weinberger
2015-04-12 14:58 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552A889F.6050307@roeck-us.net \
--to=linux@roeck-us.net \
--cc=chris@zankel.net \
--cc=jcmvbkbc@gmail.com \
--cc=jepler@unpythonic.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.