From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Ray Jui <rjui@broadcom.com>, Lee Jones <lee@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
linux-rpi-kernel@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: bcm2835: Fix support for threaded level triggered IRQs
Date: Sun, 12 Apr 2015 21:48:04 -0600 [thread overview]
Message-ID: <552B3C74.9030004@wwwdotorg.org> (raw)
In-Reply-To: <CACRpkdbRmWUYv_2cy8NebpRm5tHZJD-LiximUJ-teJb8y3hrCg@mail.gmail.com>
On 04/08/2015 08:43 AM, Linus Walleij wrote:
> On Tue, Apr 7, 2015 at 12:43 PM, Charles Keepax
> <ckeepax@opensource.wolfsonmicro.com> wrote:
>
>> Currently, the driver uses handle_simple_irq for all IRQ types and hard
>> codes the acknowledge for different IRQ types into the handler. It is
>> better to use the IRQ core as intended and let it handle the differences
>> between the various types of IRQ. For example the current system does
>> not work for threaded level triggered IRQs as these need to be masked
>> until the threaded handler has run.
>>
>> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
>
> Looks like a very fine patch so applied unless Stephen has
> some problem with it.
This patch sounds plausible to me:-)
prev parent reply other threads:[~2015-04-13 3:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 10:43 [PATCH] pinctrl: bcm2835: Fix support for threaded level triggered IRQs Charles Keepax
2015-04-08 14:43 ` Linus Walleij
2015-04-13 3:48 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552B3C74.9030004@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.