From: "Christian König" <christian.koenig@amd.com>
To: Jani Nikula <jani.nikula@intel.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/radeon: constify more struct drm_*_helper funcs pointers
Date: Mon, 13 Apr 2015 10:28:37 +0200 [thread overview]
Message-ID: <552B7E35.7050409@amd.com> (raw)
In-Reply-To: <1428913302-16195-1-git-send-email-jani.nikula@intel.com>
On 13.04.2015 10:21, Jani Nikula wrote:
> Some non-const pointers were added since the last constification, fix
> them.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
For this one Reviewed-by: Christian König <christian.koenig@amd.com>.
Can't say anything for patch #2, and #3 already has my rb IIRC.
Regards,
Christian.
> ---
> drivers/gpu/drm/radeon/radeon_connectors.c | 4 ++--
> drivers/gpu/drm/radeon/radeon_dp_mst.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
> index f150c2495fa4..cebb65e07e1d 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -751,7 +751,7 @@ static int radeon_connector_set_property(struct drm_connector *connector, struct
> if (connector->encoder)
> radeon_encoder = to_radeon_encoder(connector->encoder);
> else {
> - struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
> + const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
> radeon_encoder = to_radeon_encoder(connector_funcs->best_encoder(connector));
> }
>
> @@ -762,7 +762,7 @@ static int radeon_connector_set_property(struct drm_connector *connector, struct
>
> if (connector->encoder->crtc) {
> struct drm_crtc *crtc = connector->encoder->crtc;
> - struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
> + const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
> struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc);
>
> radeon_crtc->output_csc = radeon_encoder->output_csc;
> diff --git a/drivers/gpu/drm/radeon/radeon_dp_mst.c b/drivers/gpu/drm/radeon/radeon_dp_mst.c
> index 5952ff2bb647..1017338a49d9 100644
> --- a/drivers/gpu/drm/radeon/radeon_dp_mst.c
> +++ b/drivers/gpu/drm/radeon/radeon_dp_mst.c
> @@ -604,7 +604,7 @@ radeon_dp_create_fake_mst_encoder(struct radeon_connector *connector)
> struct radeon_encoder *radeon_encoder;
> struct radeon_encoder_mst *mst_enc;
> struct drm_encoder *encoder;
> - struct drm_connector_helper_funcs *connector_funcs = connector->base.helper_private;
> + const struct drm_connector_helper_funcs *connector_funcs = connector->base.helper_private;
> struct drm_encoder *enc_master = connector_funcs->best_encoder(&connector->base);
>
> DRM_DEBUG_KMS("enc master is %p\n", enc_master);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-04-13 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 8:21 [PATCH 1/3] drm/radeon: constify more struct drm_*_helper funcs pointers Jani Nikula
2015-04-13 8:21 ` [PATCH 2/3] drm/armada: constify struct drm_encoder_helper_funcs pointer Jani Nikula
2015-04-13 8:21 ` [PATCH 3/3] drm: make crtc/encoder/connector/plane helper_private a const pointer Jani Nikula
2015-04-13 8:25 ` Jani Nikula
2015-04-13 8:28 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552B7E35.7050409@amd.com \
--to=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.