Re: [PATCH 0/2] Re-factoring passthrough/pci.c and adding place-holder code for ARM/PCI

[Julien Grall <julien.grall@citrix.com>]

BTW, your series is not threaded.

I've already said it on another series. Please look at [1] to see how to
send correctly your series.

[1]
http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_the_patches_to_the_list

Regards,

On 13/04/15 11:19, Julien Grall wrote:
> Hi Manish,
> 
> On 13/04/15 08:37, Manish Jaggi wrote:
>> Xen currently does not have PCI support for ARM builds. This patch set
>> makes the code compilable for ARM PCI and adds places-holder code
>> which would be replaced with PCI pass-through support patch series.
> 
> May I ask why you did send directly all the code to support PCI on ARM?
> 
> Without the rest it's hard to tell whether these patches make sense or not.
> 
>> Re-factor MSI Handling
>> -------------
>> There is a some x86 specific code which is found in common code:
>> xen/drivers/passthrough/pci.c which needs to be re factored.
>>
>> MSI/X are configured and handled by dom0 or domU code on ARM64 and is not
>> required to be part of common code. However there are functions which are
>> used as part of common code and calls to these functions cannot be easily
>> re factored like pci_cleanup_msi.
> 
> On x86, the hypervisor is taking care of MSI (enabling/disabling in the
> config space) as long as doing sanity check on MSI used by a given domain.
> 
> How do you plan to handle it on ARM? IHMO, the MSI code is very useful
> and would also help GIC MSI implement (ITS + V2M).
> 
> FWIW, I've pointed out the same issue on the ITS series a couple of
> weeks ago.
> 
> Regards,
> 


-- 
Julien Grall