From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 1/8] Add core.sh and wrapper function
Date: Mon, 13 Apr 2015 11:23:57 +0100
Message-ID: <552B993D.1080700@eu.citrix.com>
References: <1428607792-13418-1-git-send-email-george.dunlap@eu.citrix.com>
	<1428607792-13418-2-git-send-email-george.dunlap@eu.citrix.com>
	<alpine.DEB.2.02.1504101154020.7690@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1504101154020.7690@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 04/10/2015 03:29 PM, Stefano Stabellini wrote:
>> diff --git a/raise b/raise
>> new file mode 100755
>> index 0000000..7f3faae
>> --- /dev/null
>> +++ b/raise
>> @@ -0,0 +1,16 @@
>> +#!/usr/bin/env bash
> 
> It is important to "set -e" immediately to catch all possible errors:
> 
>  "-e  Exit immediately if a command exits with a non-zero status."
> 
> Then you can drop set -e from raise.sh and unraise.sh when you turn them
> into libraries.

"set -e" gets tricky when you sometimes expect commands to fail;
particularly if you may want to do some sort of clean-up.  But let's
cross that bridge when we come to it. :-)

 -George