From: "Jan Beulich" <JBeulich@suse.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Olaf Hering <olaf@aepfle.de>,
xen-devel@lists.xen.org, Wei Liu <wei.liu2@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 4/4] hvmloader: add knob for fixed VGABIOS date string
Date: Mon, 13 Apr 2015 09:51:26 +0100 [thread overview]
Message-ID: <552B9FAE02000078000715BA@mail.emea.novell.com> (raw)
In-Reply-To: <1427967942.4037.29.camel@citrix.com>
>>> On 02.04.15 at 11:45, <ian.campbell@citrix.com> wrote:
> On Wed, 2015-04-01 at 13:28 +0000, Olaf Hering wrote:
>> To allow reproducible builds of hvmloader introduce a make variable
>> VGABIOS_REL_DATE="dd Mon yyyy" to provide a fixed date string. Without
>> this change the hvmloader binary changes with every rebuild.
>>
>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> It's not clear if vgabios should be maintained by us tools folks or if
> it should have been taken under the hvmloader umbrella and maintained by
> the hypervisor folks.
I'm not sure either - hvmloader is really code we grew and hence
maintaining it together with its hypervisor side makes sense. For
the various firmware blobs, otoh, I think they match more closely
with the qemu/tools pattern.
Jan
next prev parent reply other threads:[~2015-04-13 8:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 13:28 [PATCH 0/4 v2] tools: various changes Olaf Hering
2015-04-01 13:28 ` [PATCH 1/4] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file Olaf Hering
2015-04-01 13:28 ` [PATCH 2/4 v2] INSTALL: mention variables for reproducible builds Olaf Hering
2015-04-02 9:43 ` Ian Campbell
2015-04-01 13:28 ` [PATCH 3/4] hvmloader: add knob for fixed SMBIOS date string Olaf Hering
2015-04-01 13:28 ` [PATCH 4/4] hvmloader: add knob for fixed VGABIOS " Olaf Hering
2015-04-02 9:45 ` Ian Campbell
2015-04-13 8:51 ` Jan Beulich [this message]
2015-04-14 14:50 ` Ian Campbell
2015-04-02 10:13 ` [PATCH 0/4 v2] tools: various changes Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552B9FAE02000078000715BA@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.