From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v5 p2 16/19] tools/libxl: arm: Use an higher
 value for the GIC phandle
Date: Mon, 13 Apr 2015 13:07:01 +0100
Message-ID: <552BB165.2000405@citrix.com>
References: <1428592185-18581-1-git-send-email-julien.grall@citrix.com>
	<1428592185-18581-17-git-send-email-julien.grall@citrix.com>
	<21798.42495.633318.607315@mariner.uk.xensource.com>
	<5526A9ED.2000803@gmail.com>
	<21798.44594.785262.371575@mariner.uk.xensource.com>
	<5526B013.9080906@citrix.com>
	<21798.45351.475278.496458@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@citrix.com>) id 1Yhd9T-0003YS-JG
	for xen-devel@lists.xenproject.org; Mon, 13 Apr 2015 12:07:43 +0000
In-Reply-To: <21798.45351.475278.496458@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, Julien Grall <julien.grall@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, ian.campbell@citrix.com, Julien Grall <julien.grall@linaro.org>, tim@xen.org, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 09/04/15 18:04, Ian Jackson wrote:
> Julien Grall writes ("Re: [Xen-devel] [PATCH v5 p2 16/19] tools/libxl: arm: Use an higher value for the GIC phandle"):
>> On 09/04/15 17:52, Ian Jackson wrote:
>>> What would happen if our assumption about the DT compiler were
>>> violated ?
>>
>> The phandle would be present in 2 different nodes of the DT. FYI, that
>> may also happen if a user use 2 times the same phandle in the partial DT.
> 
> So we are making an assumption about the DT compiler which we don't
> check, and when the assumption is violated, we produce a corrupted DT
> which produces undefined behaviour in the guest.
> 
> Can we do some kind of check ?

As discussed IRL, I will add a note in the documentation about this
restriction.

This will be removed when the phandle will be generated dynamically.

Regards,

-- 
Julien Grall