From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yheib-0004zt-MC for qemu-devel@nongnu.org; Mon, 13 Apr 2015 09:48:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YheiY-0000XH-Gr for qemu-devel@nongnu.org; Mon, 13 Apr 2015 09:48:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YheiY-0000XD-Au for qemu-devel@nongnu.org; Mon, 13 Apr 2015 09:48:02 -0400 Message-ID: <552BC90C.7000201@redhat.com> Date: Mon, 13 Apr 2015 15:47:56 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428436304-24044-1-git-send-email-minyard@acm.org> <1428436304-24044-15-git-send-email-minyard@acm.org> <20150412180834-mutt-send-email-mst@redhat.com> <552B1C45.1080304@acm.org> <20150413082924-mutt-send-email-mst@redhat.com> <552B80CB.6040407@redhat.com> <20150413133153-mutt-send-email-mst@redhat.com> In-Reply-To: <20150413133153-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Corey Minyard , qemu-devel@nongnu.org, Corey Minyard On 13/04/2015 13:32, Michael S. Tsirkin wrote: >>>> So you are suggesting each device add it's own SSDT? I'm not sure how >>>> that helps debugging, it seems simpler to add it to a common one. >>> >>> For example, it's easier to write a unit test: encode something specific >>> in one of the IDs, then look it up. >>> Which is, btw, something that's missing in this patchset. >> >> A unit test for what? > > The ACPI code added. With an extra table it would be easy > to test that it's there. Ah, I agree that patch 15 should add something like commit 3a9c86df/71096d6c, but that doesn't need a separate table. Paolo