From: Felix Fietkau <nbd@openwrt.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH v4 4/9] bgmac: simplify rx DMA error handling
Date: Mon, 13 Apr 2015 17:05:38 +0200 [thread overview]
Message-ID: <552BDB42.1080104@openwrt.org> (raw)
In-Reply-To: <CACna6rwFcg0AKa=2h7Fg9kNZdtFY8vBNNVwXi67Bvga0v3YU0w@mail.gmail.com>
On 2015-04-13 16:53, Rafał Miłecki wrote:
> On 13 April 2015 at 15:52, Felix Fietkau <nbd@openwrt.org> wrote:
>> Unmap the DMA buffer before checking it. If it is poisoned, map it again
>> and pass it back to the hardware.
>
> Where exactly do you map it again? I can't see it. It's not handled in
> bgmac_dma_rx_setup_desc. Also keep in mind that mapping may fail -
> this is why old code doesn't unmap anything until a new buffer is
> really ready. How do you want to deal with mapping error after
> unmapping a buffer?
You're right, seems that I accidentally dropped a chunk of the patch.
- Felix
next prev parent reply other threads:[~2015-04-13 15:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 13:52 [PATCH v4 1/9] bgmac: simplify tx ring index handling Felix Fietkau
2015-04-13 13:52 ` [PATCH v4 2/9] bgmac: leave interrupts disabled as long as there is work to do Felix Fietkau
2015-04-13 14:34 ` Rafał Miłecki
2015-04-13 15:03 ` Felix Fietkau
2015-04-13 15:06 ` Rafał Miłecki
2015-04-13 15:44 ` Felix Fietkau
2015-04-13 16:35 ` Rafał Miłecki
2015-04-13 13:52 ` [PATCH v4 3/9] bgmac: set received skb headroom to NET_SKB_PAD Felix Fietkau
2015-04-13 13:52 ` [PATCH v4 4/9] bgmac: simplify rx DMA error handling Felix Fietkau
2015-04-13 14:53 ` Rafał Miłecki
2015-04-13 15:05 ` Felix Fietkau [this message]
2015-04-13 13:52 ` [PATCH v4 5/9] bgmac: add check for oversized packets Felix Fietkau
2015-04-13 13:52 ` [PATCH v4 6/9] bgmac: increase rx ring size from 511 to 512 Felix Fietkau
2015-04-13 13:52 ` [PATCH v4 7/9] bgmac: simplify dma init/cleanup Felix Fietkau
2015-04-13 13:52 ` [PATCH v4 8/9] bgmac: fix DMA rx corruption Felix Fietkau
2015-04-13 13:52 ` [PATCH v4 9/9] bgmac: drop ring->num_slots Felix Fietkau
2015-04-13 14:21 ` [PATCH v4 1/9] bgmac: simplify tx ring index handling Rafał Miłecki
2015-04-13 15:01 ` Felix Fietkau
2015-04-13 18:05 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552BDB42.1080104@openwrt.org \
--to=nbd@openwrt.org \
--cc=hauke@hauke-m.de \
--cc=netdev@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.