From: Felix Fietkau <nbd@openwrt.org>
To: David Miller <davem@davemloft.net>, romieu@fr.zoreil.com
Cc: netdev@vger.kernel.org, zajec5@gmail.com, hauke@hauke-m.de
Subject: Re: [PATCH v5 4/9] bgmac: simplify rx DMA error handling
Date: Tue, 14 Apr 2015 02:05:18 +0200 [thread overview]
Message-ID: <552C59BE.4010506@openwrt.org> (raw)
In-Reply-To: <20150413.200408.109329017927025696.davem@davemloft.net>
On 2015-04-14 02:04, David Miller wrote:
> From: Francois Romieu <romieu@fr.zoreil.com>
> Date: Tue, 14 Apr 2015 01:20:40 +0200
>
>> Felix Fietkau <nbd@openwrt.org> :
>>> Unmap the DMA buffer before checking it. If an error occurs, free the
>>> buffer and allocate a new one. If allocation or mapping fails, retry as
>>> long as there is NAPI poll budget left (count every attempt instead of
>>> every frame).
>>
>> The driver is not supposed to use the NAPI budget this way.
>>
>> If the driver can't reserve resources to handle the packet, it should
>> drop the data, keep everything in place for the hardware and move to the
>> next slot.
>
> +1
Fixed in v6.
- Felix
next prev parent reply other threads:[~2015-04-14 0:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 17:27 [PATCH v5 1/9] bgmac: simplify tx ring index handling Felix Fietkau
2015-04-13 17:27 ` [PATCH v5 2/9] bgmac: leave interrupts disabled as long as there is work to do Felix Fietkau
2015-04-13 17:27 ` [PATCH v5 3/9] bgmac: set received skb headroom to NET_SKB_PAD Felix Fietkau
2015-04-13 17:27 ` [PATCH v5 4/9] bgmac: simplify rx DMA error handling Felix Fietkau
2015-04-13 19:47 ` Felix Fietkau
2015-04-13 23:20 ` Francois Romieu
2015-04-14 0:04 ` David Miller
2015-04-14 0:05 ` Felix Fietkau [this message]
2015-04-13 17:27 ` [PATCH v5 5/9] bgmac: add check for oversized packets Felix Fietkau
2015-04-13 17:27 ` [PATCH v5 6/9] bgmac: increase rx ring size from 511 to 512 Felix Fietkau
2015-04-13 17:27 ` [PATCH v5 7/9] bgmac: simplify dma init/cleanup Felix Fietkau
2015-04-13 17:27 ` [PATCH v5 8/9] bgmac: fix DMA rx corruption Felix Fietkau
2015-04-13 17:27 ` [PATCH v5 9/9] bgmac: drop ring->num_slots Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552C59BE.4010506@openwrt.org \
--to=nbd@openwrt.org \
--cc=davem@davemloft.net \
--cc=hauke@hauke-m.de \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.