From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yhraj-0006h1-ND for qemu-devel@nongnu.org; Mon, 13 Apr 2015 23:32:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yhrag-0007wD-Hb for qemu-devel@nongnu.org; Mon, 13 Apr 2015 23:32:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yhrag-0007w5-C5 for qemu-devel@nongnu.org; Mon, 13 Apr 2015 23:32:46 -0400 Message-ID: <552C8A5B.9070206@redhat.com> Date: Mon, 13 Apr 2015 21:32:43 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427995743-7865-1-git-send-email-armbru@redhat.com> <1427995743-7865-17-git-send-email-armbru@redhat.com> In-Reply-To: <1427995743-7865-17-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iGoCvsrbXie3iB6Kp3uOF21TFFO4IMfAm" Subject: Re: [Qemu-devel] [PATCH RFC 16/19] qobject: Clean up around qtype_code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, akong@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iGoCvsrbXie3iB6Kp3uOF21TFFO4IMfAm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/02/2015 11:29 AM, Markus Armbruster wrote: > QTYPE_NONE is a sentinel value. No QObject has this type code. > Document it properly. >=20 > Fix dump_qobject() to abort() on QTYPE_NONE, just like for any other > invalid type code. >=20 > Fix to_json() to abort() on all invalid type codes, not just > QTYPE_MAX. >=20 > Clean up Property member qtype's type: it's a qtype_code. >=20 > Signed-off-by: Markus Armbruster > --- > block/qapi.c | 3 --- > include/hw/qdev-core.h | 2 +- > include/qapi/qmp/qobject.h | 2 +- > qobject/qjson.c | 3 +-- > 4 files changed, 3 insertions(+), 7 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --iGoCvsrbXie3iB6Kp3uOF21TFFO4IMfAm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVLIpbAAoJEKeha0olJ0NqEjUIAJ6+veAQkIh83WowXpDT8DdQ apZhh6OX3zs4J7KVrCsUmx8rtiQMBVhDPQcgAByrC8jvZ0CKpQk3ss5k7qazt17V J5+PmB3V+C+bNDjo3sE8anlOGjOiw/8CX5Hqsjsm5c5rEmGBhU58DwWVmquRbNbN 64qm7+mLPDsrS1bDOkSVaJT2WvAaJudimsTRLt1Zi5IltJCVS+3gKXHf2J6WkaUc HagiXXRQsGr22VPEfKo040/THPPnBhD/TJhzgSW9C0JZH62THnLzJeYkTR4y2kSo FmCxegLdcYxNZNJo6bL0LKuTPu2xJpdzH1UKBTUkEhCRvJJkBzu7gKvgSqhDl7c= =kW0E -----END PGP SIGNATURE----- --iGoCvsrbXie3iB6Kp3uOF21TFFO4IMfAm--