From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH v4 2/3] mtd, nand: move common functions from cmd_nand.c to common place
Date: Tue, 14 Apr 2015 08:21:19 +0200 [thread overview]
Message-ID: <552CB1DF.7040301@denx.de> (raw)
In-Reply-To: <1428957158.22867.635.camel@freescale.com>
Hello Scott,
Am 13.04.2015 22:32, schrieb Scott Wood:
> On Sun, 2015-04-12 at 10:12 +0200, Heiko Schocher wrote:
>> @@ -595,7 +491,10 @@ static int do_nand(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>> printf("\nNAND %s: ", cmd);
>> /* skip first two or three arguments, look for offset and size */
>> if (arg_off_size(argc - o, argv + o, &dev, &off, &size,
>> - &maxsize) != 0)
>> + &maxsize, MTD_DEV_TYPE_NAND, nand_info[dev].size) != 0)
>
> Please keep the continuation line aligned with the arguments, not the
> function name (here and elsewhere).
Good catch! Fixed. Wait for more comments before posting v5 ...
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2015-04-14 6:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 8:12 [U-Boot] [RESEND PATCH v4 0/3] spi, sf: add mtdparts feature to spi and sf commands Heiko Schocher
2015-04-12 8:12 ` [U-Boot] [RESEND PATCH v4 1/3] mtd, spi: add MTD layer driver Heiko Schocher
2015-04-12 8:12 ` [U-Boot] [RESEND PATCH v4 2/3] mtd, nand: move common functions from cmd_nand.c to common place Heiko Schocher
2015-04-13 20:32 ` Scott Wood
2015-04-14 6:21 ` Heiko Schocher [this message]
2015-04-12 8:12 ` [U-Boot] [RESEND PATCH v4 3/3] spi, sf: use offset and size in sf cmd from mtdpartition Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552CB1DF.7040301@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.