All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: linux-sparse@vger.kernel.org
Cc: sparse@chrisli.org
Subject: [PATCH 1/2] compiler/gcc5: Remove quirk for asm_volatile_goto()
Date: Tue, 14 Apr 2015 11:25:04 +0200	[thread overview]
Message-ID: <552CDCF0.3050401@suse.cz> (raw)

Remove comments related to GCC 4.x branch and workaround for
asm_volatile_goto which is fixed in GCC 5 release.

Signed-off-by: Martin Liska  <mliska@suse.cz>
---
  include/linux/compiler-gcc5.h | 16 ++--------------
  1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/include/linux/compiler-gcc5.h b/include/linux/compiler-gcc5.h
index efee493..1ded0a0 100644
--- a/include/linux/compiler-gcc5.h
+++ b/include/linux/compiler-gcc5.h
@@ -12,10 +12,6 @@
     like BUG(), printk(), panic() etc. [but let's keep them for now for
     older compilers]
  
-   Early snapshots of gcc 4.3 don't support this and we can't detect this
-   in the preprocessor, but we can live with this because they're unreleased.
-   Maketime probing would be overkill here.
-
     gcc also has a __attribute__((__hot__)) to move hot functions into
     a special section, but I don't see any sense in this right now in
     the kernel context */
@@ -32,10 +28,6 @@
   * Mark a position in code as unreachable.  This can be used to
   * suppress control flow warnings after asm blocks that transfer
   * control elsewhere.
- *
- * Early snapshots of gcc 4.5 don't support this and we can't detect
- * this in the preprocessor, but we can live with this because they're
- * unreleased.  Really, we need to have autoconf for the kernel.
   */
  #define unreachable() __builtin_unreachable()
  
@@ -48,15 +40,11 @@
  #define __visible __attribute__((externally_visible))
  
  /*
- * GCC 'asm goto' miscompiles certain code sequences:
+ * 'asm goto' miscompilation is fixed in GCC 5.x version:
   *
   *   http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58670
- *
- * Work it around via a compiler barrier quirk suggested by Jakub Jelinek.
- *
- * (asm goto is automatically volatile - the naming reflects this.)
   */
-#define asm_volatile_goto(x...)	do { asm goto(x); asm (""); } while (0)
+#define asm_volatile_goto(x...)	do { asm goto(x); } while (0)
  
  #ifdef CONFIG_ARCH_USE_BUILTIN_BSWAP
  #define __HAVE_BUILTIN_BSWAP32__
-- 
2.1.4



             reply	other threads:[~2015-04-14  9:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14  9:25 Martin Liška [this message]
2015-04-14 17:58 ` [PATCH 1/2] compiler/gcc5: Remove quirk for asm_volatile_goto() Linus Torvalds
2015-04-15  9:08   ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552CDCF0.3050401@suse.cz \
    --to=mliska@suse.cz \
    --cc=linux-sparse@vger.kernel.org \
    --cc=sparse@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.