From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain Date: Tue, 14 Apr 2015 13:47:19 +0100 Message-ID: <552D0C57.8070107@gmail.com> References: <551505B3.9020505@caviumnetworks.com> , <55155557.7020103@linaro.org> <1427462781997.9237@caviumnetworks.com> <1427877031.2115.212.camel@citrix.com> <55229518.4010306@citrix.com> <1429010110.15516.34.camel@citrix.com>, <552CFE30.70802@gmail.com> <1429014241210.43895@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1429014241210.43895@caviumnetworks.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Jaggi, Manish" , Ian Campbell , Julien Grall Cc: "Prasun.kapoor@cavium.com" , "Kumar, Vijaya" , Julien Grall , Xen Devel , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 14/04/15 13:24, Jaggi, Manish wrote: > [manish] Table is indeed a good option, but I think changing the name > of arm_smmu_xen_device to something like arch_smmu_device make more > sense as arm_smmu_xen_device and arm_smmu_device are not differentiable > just by name. Can you explain how arch_smmu_device and arm_smmu_device are easier to differentiate? There is only 2 letters difference... Also, what does "arch" stands for? The SMMU driver is already ARM specific... Regards, -- Julien Grall