From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()
Date: Tue, 14 Apr 2015 16:30:54 +0200 [thread overview]
Message-ID: <552D249E.3000302@redhat.com> (raw)
In-Reply-To: <CAFEAcA8DL7=RaAt9HyNLWroPNs9+detW0c-VhaTZ2TqyPD2v-g@mail.gmail.com>
On 14/04/2015 15:41, Peter Maydell wrote:
> No, this is not-for-2.3. I think that the issue here is that
> merely adding -m32 isn't sufficient, because pkg-config when
> run by configure will end up pointing at a bunch of incorrect
> glib includes (for x86-64, not i386). So the actual solution
> is to give configure the right pkg-config, and then gsize and
> size_t are the same. There's a patch by John Snow for
> configure on-list for that.
Ah, that's reassuring. :) I was surprised by the timing and by Michael
asking whether he should have posted a pull request.
Paolo
next prev parent reply other threads:[~2015-04-14 14:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 20:02 [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode() Peter Maydell
2015-04-08 20:14 ` Michael Roth
2015-04-14 13:38 ` Thomas Huth
2015-04-14 13:41 ` Peter Maydell
2015-04-14 14:30 ` Paolo Bonzini [this message]
2015-04-14 13:42 ` Paolo Bonzini
2015-04-14 13:45 ` Peter Maydell
2015-04-14 14:29 ` Paolo Bonzini
2015-04-14 14:35 ` Eric Blake
2015-04-14 14:50 ` Paolo Bonzini
2015-04-14 15:12 ` Eric Blake
2015-04-14 14:36 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552D249E.3000302@redhat.com \
--to=pbonzini@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.