From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi1w8-00037O-9w for qemu-devel@nongnu.org; Tue, 14 Apr 2015 10:35:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yi1w4-00021h-N1 for qemu-devel@nongnu.org; Tue, 14 Apr 2015 10:35:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi1w3-00021a-SY for qemu-devel@nongnu.org; Tue, 14 Apr 2015 10:35:32 -0400 Message-ID: <552D25B2.4010002@redhat.com> Date: Tue, 14 Apr 2015 08:35:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428523369-13700-1-git-send-email-peter.maydell@linaro.org> <552D1940.5030709@redhat.com> <552D2451.5040403@redhat.com> In-Reply-To: <552D2451.5040403@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o5uSpxGJqckMsWrs3xXtSaHfItjAm5xk7" Subject: Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Peter Maydell Cc: Patch Tracking , Michael Roth , QEMU Developers This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --o5uSpxGJqckMsWrs3xXtSaHfItjAm5xk7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/14/2015 08:29 AM, Paolo Bonzini wrote: > But you can: gsize is defined to be "An unsigned integer type of the > result of the sizeof operator, corresponding to the size_t type defined= > in C99. Good so far. > This type is wide enough to hold the numeric value of a pointer, Not true on platforms where size_t is 32 bits but pointers are 64 bits. Bug in glib documentation. >=20 > If anything, I would add a QEMU_BUILD_BUG_ON(sizeof(gsize) !=3D > sizeof(size_t)) to catch the problem, since we've had many experienced > developers caught unprepared. That would be my preference as well. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --o5uSpxGJqckMsWrs3xXtSaHfItjAm5xk7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVLSWyAAoJEKeha0olJ0NqkqEIAKzxv4kNWnvlvl9ML/Bnfkdz nSrFlnuJhCIBPd2rRz0zfRCRSWg3gLMmgRrpe4fI1gvV+yRoPAjxg+lEzHT/c6e2 xZ5eHzPuJUIj4xCLfaeK+6YJJZ/FE/6mx7xmWvNWxF/PU1CbgbbRTfhqgIo4/w8a mvxMW/K/l2xiLcriMS+GSybaa5txMRv+5gQBeS6JzCmv8Tge7Fz337ISS977wCyI YYkl6Ovlen0vS/YEIw4vfAftHUggm85b4HIlpirpbb+3Z8UAy0KmhwpgC+2KOazh xGcQBo9kIoYkwmchSYS6zWsFmQlq13QizZV4+lCjTpKGLQSox2e8/Y0htYcjePs= =/wXp -----END PGP SIGNATURE----- --o5uSpxGJqckMsWrs3xXtSaHfItjAm5xk7--