From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v2] spi: bitbang: Make setup_transfer() callback optional Date: Tue, 14 Apr 2015 12:36:22 -0300 Message-ID: <552D33F6.2020407@vanguardiasur.com.ar> References: <1428919685-14190-1-git-send-email-per.nilsson@xelmo.com> <1429018817-18117-1-git-send-email-per.nilsson@xelmo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, nios2-dev-g9ZBwUv/Ih/yUk5EbOjzuce+I+R0W71w@public.gmane.org To: Pelle Nilsson , broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Return-path: In-Reply-To: <1429018817-18117-1-git-send-email-per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 04/14/2015 10:40 AM, Pelle Nilsson wrote: > Some controller drivers have no need of this callback (spi-altera even > causes a NULL pointer dereference because it doesn't register the callback, > falsely assuming that it is already optional). > > Fixes: 30af9b558a56 ("spi/bitbang: Drop empty setup() functions") > Signed-off-by: Pelle Nilsson Reviewed-by: Ezequiel Garcia Please note the merge window is open, so don't expect Mark to pick your change soon. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753869AbbDNPjT (ORCPT ); Tue, 14 Apr 2015 11:39:19 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:38216 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753585AbbDNPjM (ORCPT ); Tue, 14 Apr 2015 11:39:12 -0400 Message-ID: <552D33F6.2020407@vanguardiasur.com.ar> Date: Tue, 14 Apr 2015 12:36:22 -0300 From: Ezequiel Garcia Organization: VanguardiaSur User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Pelle Nilsson , broonie@kernel.org CC: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, nios2-dev@lists.rocketboards.org Subject: Re: [PATCH v2] spi: bitbang: Make setup_transfer() callback optional References: <1428919685-14190-1-git-send-email-per.nilsson@xelmo.com> <1429018817-18117-1-git-send-email-per.nilsson@xelmo.com> In-Reply-To: <1429018817-18117-1-git-send-email-per.nilsson@xelmo.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/14/2015 10:40 AM, Pelle Nilsson wrote: > Some controller drivers have no need of this callback (spi-altera even > causes a NULL pointer dereference because it doesn't register the callback, > falsely assuming that it is already optional). > > Fixes: 30af9b558a56 ("spi/bitbang: Drop empty setup() functions") > Signed-off-by: Pelle Nilsson Reviewed-by: Ezequiel Garcia Please note the merge window is open, so don't expect Mark to pick your change soon. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar