All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Akinobu Mita <akinobu.mita@gmail.com>,
	Sagi Grimberg <sagig@mellanox.com>
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	target-devel@vger.kernel.org,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.
Date: Tue, 14 Apr 2015 20:20:59 +0300	[thread overview]
Message-ID: <552D4C7B.9000402@dev.mellanox.co.il> (raw)
In-Reply-To: <CAC5umygZ_qCu0x3RfTQs21R1Poa6A10FkhmGak7ccc2HvY4ROQ@mail.gmail.com>

On 4/14/2015 3:17 PM, Akinobu Mita wrote:
> 2015-04-14 2:19 GMT+09:00 Sagi Grimberg <sagig@mellanox.com>:
>> Hey All,
>>
>> This set follows the patchset from Akinobu Mita that addresses
>> DIF bounce buffer sgl construction. Instead of trying to fix these
>> bugs, this removes it altogether and work with cmd->t_prot_sg
>> directly.
>>
>> The first patch is a simplification of the DIF verify varius
>> routines leaving a single generic sbc_dif_verify that handles
>> the protection information sgl we are working on.
>>
>> The second patch uses this simplification to remove the local
>> prot_fd bounce buffer altogether.
>>
>> This passed minimal IO testing.
>
> Looks good...
>
> I'll test with these patches and check if the problems I met
> disappear.

Thanks Akinobu,

Waiting to hear your verdict before sending a formal patchset.

Sagi.

  reply	other threads:[~2015-04-14 17:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13 17:19 [RFC] Simlify dif_verify routines and fixup fileio protection information code Sagi Grimberg
2015-04-13 17:19 ` [PATCH RFC 1/2] target: Merge sbc_verify_dif_read|write Sagi Grimberg
2015-04-13 17:19 ` [PATCH RFC 2/2] target/file: Remove fd_prot bounce buffer Sagi Grimberg
2015-04-14  1:23 ` [RFC] Simlify dif_verify routines and fixup fileio protection information code Martin K. Petersen
2015-04-14 12:17 ` Akinobu Mita
2015-04-14 17:20   ` Sagi Grimberg [this message]
2015-04-14 23:52     ` Akinobu Mita
2015-04-15 10:07       ` Sagi Grimberg
2015-04-15 14:16         ` Akinobu Mita
2015-04-15 14:33           ` Sagi Grimberg
2015-04-15 15:05             ` Martin K. Petersen
2015-04-15 15:08             ` Sagi Grimberg
2015-04-15 16:10               ` Martin K. Petersen
2015-04-16  8:52                 ` Sagi Grimberg
2015-04-16 13:46                   ` Akinobu Mita
2015-04-16 15:30                     ` Martin K. Petersen
2015-04-16 15:58                     ` Sagi Grimberg
2015-04-16 16:04                       ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552D4C7B.9000402@dev.mellanox.co.il \
    --to=sagig@dev.mellanox.co.il \
    --cc=akinobu.mita@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nab@linux-iscsi.org \
    --cc=sagig@mellanox.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.