From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 942CFE0098A; Tue, 14 Apr 2015 11:24:36 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, SPF_HELO_PASS,T_DKIM_INVALID autolearn=no version=3.3.1 X-Spam-HAM-Report: * -0.0 SPF_HELO_PASS SPF: HELO matches SPF record * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid Received: from compulab.co.il (softlayer.compulab.co.il [50.23.254.55]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 02001E0076B for ; Tue, 14 Apr 2015 11:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=compulab.co.il; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=VS374VfXMawOefVq0cDMKpnNLneQfWb3tMcyysbrRYA=; b=GMzChRvFm0nKvLQZIsPVLcO9fQCCtfPGL979VTYE71Sp3dgWsggoSa2ArA2+S/m2dlgzGixnzVkq1hI97QK63NXv1OR8wx+YmbWOMfzSiRnBznCWeJsjip+kp0N22BFS32mL1Op1vtdsS9iQ9dNujUONRyPylxRaOs4j1wIlMyc=; Received: from [62.90.235.247] (port=20441 helo=zimbra-mta.compulab.co.il) by softlayer.compulab.co.il with esmtp (Exim 4.85) (envelope-from ) id 1Yi5Vi-0003AV-NE; Tue, 14 Apr 2015 21:24:34 +0300 Received: from localhost (localhost [127.0.0.1]) by zimbra-mta.compulab.co.il (Postfix) with ESMTP id ED07048A0AB; Tue, 14 Apr 2015 21:24:33 +0300 (IDT) Received: from zimbra-mta.compulab.co.il ([127.0.0.1]) by localhost (zimbra-mta.compulab.co.il [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 4r_qZ0lIaxmm; Tue, 14 Apr 2015 21:24:33 +0300 (IDT) Received: from localhost (localhost [127.0.0.1]) by zimbra-mta.compulab.co.il (Postfix) with ESMTP id 4125448A0A9; Tue, 14 Apr 2015 21:24:33 +0300 (IDT) X-Virus-Scanned: amavisd-new at zimbra-mta.compulab.co.il Received: from zimbra-mta.compulab.co.il ([127.0.0.1]) by localhost (zimbra-mta.compulab.co.il [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UU8b-jyPxPnF; Tue, 14 Apr 2015 21:24:33 +0300 (IDT) Received: from [192.168.11.13] (grinberg-linux.compulab.local [192.168.11.13]) by zimbra-mta.compulab.co.il (Postfix) with ESMTP id 1B89B48A0A1; Tue, 14 Apr 2015 21:24:33 +0300 (IDT) Message-ID: <552D5B60.8060402@compulab.co.il> Date: Tue, 14 Apr 2015 21:24:32 +0300 From: Igor Grinberg Organization: CompuLab Ltd. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Otavio Salvador , Valentin Raevsky References: <1428745165-24991-1-git-send-email-valentin@compulab.co.il> <1428745165-24991-3-git-send-email-valentin@compulab.co.il> In-Reply-To: X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - softlayer.compulab.co.il X-AntiAbuse: Original Domain - yoctoproject.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - compulab.co.il X-Get-Message-Sender-Via: softlayer.compulab.co.il: acl_c_relayhosts_text_entry: grinberg@compulab.co.il|compulab.co.il Cc: "meta-freescale@yoctoproject.org" Subject: Re: [PATCH 3/3] cm-fx6: add cm-fx6 machine configuration X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2015 18:24:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 04/13/15 16:47, Otavio Salvador wrote: > On Sat, Apr 11, 2015 at 6:39 AM, Valentin Raevsky > wrote: >> Add cm-fx6 machine configuration: u-boot and kernel. >> The cm-fx6 is a CompuLab CoM. The board features: >> -- Freescale i.MX6 quad-core Cortex-A9 CPU, 1.2GHz > > Quad / DualLite ? Yes, thanks. We use Quad, Dual, and Solo (DL). > >> -- Up to 4GB DDR3 and up to 32GB on-board SSD storage >> -- Integrated GPU and 1080p VPU, dual display support >> -- WiFi, BT 3.0, GbE, PCIe, SATA, USB x5, UART x5, CAN x2 >> >> For more information visit: >> http://www.compulab.co.il/products/computer-on-modules/cm-fx6/ > > Great :) > >> Signed-off-by: Valentin Raevsky >> --- >> conf/machine/cm-fx6.conf | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> create mode 100644 conf/machine/cm-fx6.conf >> >> diff --git a/conf/machine/cm-fx6.conf b/conf/machine/cm-fx6.conf >> new file mode 100644 >> index 0000000..1b357cd >> --- /dev/null >> +++ b/conf/machine/cm-fx6.conf >> @@ -0,0 +1,22 @@ >> +#@TYPE: Machine >> +#@NAME: CompuLab CM-FX6 >> +#@SOC: i.MX6 Q/DL >> +#@DESCRIPTION: Machine configuration for CompuLab CM-FX6 machines >> +#@MAINTAINER: Valentin Raevsky > > Great. > >> +require conf/machine/include/imx-base.inc Valentin told me that including this results in some strange build breakage... Is it because we tried with kernel kernel 3.10.17? >> +require conf/machine/include/tune-cortexa9.inc >> + >> +SOC_FAMILY = "mx6:mx6dl:mx6q" >> + >> +PREFERRED_PROVIDER_u-boot = "u-boot-cm-fx6" >> +PREFERRED_PROVIDER_virtual/kernel = "linux-cm-fx6" > > This will need to be adjusted for v2, as part of the renaming. No problem, I just want to understand, how should we add boards to the same recipes (linux-compulab, u-boot-compulab). > > ... >> +KERNEL_IMAGETYPE = "zImage" > > zImage is the BSP layer default so please drop it. Ok. > > Apart from this, it is very good. > > Generally the most important remark is the way you've been sending the > patchset. You need to add the proper subject-prefix when sending it. > > You can take a look at the README[1] as it describes the proper way to do it. > > 1. https://github.com/Freescale/meta-fsl-arm-extra Thanks for the pointer! > > Thanks for the hard work you've been doing at cooking this patches. I > know the first iterations are tough but this ends being a pleasant > experience as soon you get more used to it, I apologize in send so > many "remarks" to the patchset but those are necessary so we can keep > the good level of quality of the BSP layer in long term. Well, thank you for reviewing those patches and being patient! We have a mutual goal, so no problem with remarks or their amount. As more remarks come in now, less we will have to deal with later ;-) -- Regards, Igor.