From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Shriram Rajagopalan <rshriram@cs.ubc.ca>,
Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH v2 1/1] tools: Handle xc_maxmem adjustments
Date: Wed, 15 Apr 2015 10:53:13 +0100 [thread overview]
Message-ID: <552E3509.8010107@citrix.com> (raw)
In-Reply-To: <1429049186-27343-1-git-send-email-dslutz@verizon.com>
On 14/04/15 23:06, Don Slutz wrote:
> This fixes an issue where "xl save" followed by "xl restore" reports:
> "xc: error: Failed to allocate memory for batch.!: Internal error"
>
> One of the ways to get into this state is to have more then 4 e1000
> nics configured.
>
> Signed-off-by: Don Slutz <dslutz@verizon.com>
I still don't think this is the correct solution, although I will
concede that this is a far better patch than v1.
Going back to the original problem, why does Qemu need to change maxmem
in the first place? You talk about e1000 option roms, but the option
roms themselves must be allocated in an appropriate PCI bridge window.
As a result, there is necessarily already ram backing, which can be
ballooned back in. Currently, all ram behind the PCI MMIO is ballooned
out hvmloader but still accounted to the domain, and otherwise wasted.
~Andrew
next prev parent reply other threads:[~2015-04-15 9:53 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 16:09 [PATCH 1/1] xc_domain_restore: Allow QEMU to increase memory Don Slutz
2015-04-13 16:20 ` Wei Liu
2015-04-13 23:51 ` Don Slutz
2015-04-13 16:25 ` Andrew Cooper
2015-04-13 23:51 ` Don Slutz
2015-04-14 8:53 ` Wei Liu
2015-04-14 17:34 ` Don Slutz
2015-04-14 17:51 ` Wei Liu
2015-04-15 9:46 ` Stefano Stabellini
2015-04-15 10:09 ` Ian Campbell
2015-04-15 11:15 ` Hongyang Yang
2015-04-15 11:27 ` Stefano Stabellini
2015-04-15 11:56 ` Ian Campbell
2015-04-15 18:19 ` Don Slutz
2015-04-14 8:53 ` Andrew Cooper
2015-04-14 9:22 ` Hongyang Yang
2015-04-14 9:28 ` Andrew Cooper
2015-04-14 9:42 ` Hongyang Yang
2015-04-15 14:32 ` Ian Campbell
2015-04-15 20:41 ` Don Slutz
2015-04-14 9:29 ` Wei Liu
2015-04-14 9:40 ` Hongyang Yang
2015-04-14 9:52 ` Wei Liu
2015-04-14 17:43 ` Don Slutz
2015-04-14 17:54 ` Wei Liu
2015-04-14 22:06 ` [PATCH v2 1/1] tools: Handle xc_maxmem adjustments Don Slutz
2015-04-15 9:53 ` Andrew Cooper [this message]
2015-04-15 9:57 ` Stefano Stabellini
2015-04-15 10:03 ` Andrew Cooper
2015-04-15 10:21 ` George Dunlap
2015-04-15 11:48 ` Stefano Stabellini
2015-04-15 21:43 ` Don Slutz
2015-04-15 10:16 ` George Dunlap
2015-04-15 10:25 ` George Dunlap
2015-04-15 10:30 ` Andrew Cooper
2015-04-15 14:34 ` [PATCH 1/1] xc_domain_restore: Allow QEMU to increase memory Ian Campbell
2015-04-15 16:36 ` Wei Liu
2015-04-15 16:45 ` Ian Campbell
2015-04-15 16:52 ` Wei Liu
2015-04-15 18:24 ` Don Slutz
2015-04-16 9:00 ` Ian Campbell
2015-04-16 9:14 ` George Dunlap
2015-04-16 9:29 ` Ian Campbell
2015-04-14 3:46 ` Hongyang Yang
2015-04-14 8:46 ` Wei Liu
2015-04-15 14:30 ` Ian Campbell
2015-04-15 18:17 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552E3509.8010107@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=dslutz@verizon.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.