From: Paolo Bonzini <pbonzini@redhat.com>
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
Andres Lagar-Cavilla <andreslc@google.com>
Cc: Wanpeng Li <wanpeng.li@linux.intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Northup <digitaleric@google.com>
Subject: Re: [PATCH] KVM: MMU: fix comment in kvm_mmu_zap_collapsible_spte
Date: Wed, 15 Apr 2015 17:05:48 +0200 [thread overview]
Message-ID: <552E7E4C.5020804@redhat.com> (raw)
In-Reply-To: <552C91BA.1010703@linux.intel.com>
> - * Only EPT supported for now; otherwise, one would need to
> - * find out efficiently whether the guest page tables are
> - * also using huge pages.
> + * We can not do huge page mapping for the indirect shadow
> + * page (sp) found on the last rmap (level = 1 ) since
> + * indirect sp is synced with the page table in guest and
> + * indirect sp->level = 1 means the guest page table is
> + * using 4K page size mapping.
What about:
+ * We cannot do huge page mapping for indirect shadow pages,
+ * which are found on the last rmap (level = 1) when not using
+ * tdp; such shadow pages are synced with the page table in
+ * the guest, and the guest page table is using 4K page size
+ * mapping if the indirect sp has level = 1.
next prev parent reply other threads:[~2015-04-15 15:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 7:40 [PATCH v3] kvm: mmu: lazy collapse small sptes into large sptes Wanpeng Li
2015-04-07 15:41 ` Paolo Bonzini
2015-04-10 18:05 ` Andres Lagar-Cavilla
2015-04-13 1:45 ` Xiao Guangrong
2015-04-13 5:59 ` Wanpeng Li
2015-04-13 6:31 ` Andres Lagar-Cavilla
2015-04-14 4:04 ` [PATCH] KVM: MMU: fix comment in kvm_mmu_zap_collapsible_spte Xiao Guangrong
2015-04-15 15:05 ` Paolo Bonzini [this message]
2015-04-16 0:38 ` Xiao Guangrong
2015-04-16 8:14 ` Wanpeng Li
2015-04-14 5:25 ` [PATCH v3] kvm: mmu: lazy collapse small sptes into large sptes Wanpeng Li
2015-04-14 6:06 ` Andres Lagar-Cavilla
2015-04-14 6:38 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552E7E4C.5020804@redhat.com \
--to=pbonzini@redhat.com \
--cc=andreslc@google.com \
--cc=digitaleric@google.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.