From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH 1/1] xc_domain_restore: Allow QEMU to
 increase memory
Date: Wed, 15 Apr 2015 14:17:51 -0400
Message-ID: <552EAB4F.208@one.verizon.com>
References: <1428941353-18673-1-git-send-email-dslutz@verizon.com>
	<1429108252.15516.301.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1429108252.15516.301.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Shriram Rajagopalan <rshriram@cs.ubc.ca>, Yang Hongyang <yanghy@cn.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

On 04/15/15 10:30, Ian Campbell wrote:
> On Mon, 2015-04-13 at 12:09 -0400, Don Slutz wrote:
>>  
>> +/* Leave some slack so that hvmloader does not complain about lack of
>> + * memory at boot time ("Could not allocate order=0 extent").
>> + * Once hvmloader is modified to cope with that situation without
>> + * printing warning messages, QEMU_SPARE_PAGES can be removed.
> 
> How and where is hvmloader involved in a domain restore? 
> 

If the domU is created paused, saved, and restored, hvmloader will be
the 1st thing to execute.  This comment is in QEMU and this old (bad)
way needed to leave room for hvmloader.

My understanding is that when xc_domain_populate_physmap_exact() returns
an error (which outputs and error on the console), hvmloader
will "correctly handle this.

   -Don Slutz

> Ian.
>