From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH 1/1] xc_domain_restore: Allow QEMU to
 increase memory
Date: Wed, 15 Apr 2015 14:19:34 -0400
Message-ID: <552EABB6.8000902@one.verizon.com>
References: <1428941353-18673-1-git-send-email-dslutz@verizon.com>	
	<552BEDF1.7070209@citrix.com> <552C5683.1040903@one.verizon.com>	
	<20150414085304.GM17670@zion.uk.xensource.com>	
	<552D4FB3.9060109@one.verizon.com>	
	<alpine.DEB.2.02.1504151044520.7690@kaball.uk.xensource.com>	
	<1429092570.15516.172.camel@citrix.com>
	<552E485F.5090805@cn.fujitsu.com>	
	<alpine.DEB.2.02.1504151225440.7690@kaball.uk.xensource.com>
	<1429098969.15516.234.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1429098969.15516.234.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Shriram Rajagopalan <rshriram@cs.ubc.ca>, Hongyang Yang <yanghy@cn.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

On 04/15/15 07:56, Ian Campbell wrote:
> On Wed, 2015-04-15 at 12:27 +0100, Stefano Stabellini wrote:
>> On Wed, 15 Apr 2015, Hongyang Yang wrote:
>>> On 04/15/2015 06:09 PM, Ian Campbell wrote:
>>>> On Wed, 2015-04-15 at 10:46 +0100, Stefano Stabellini wrote:
>>>>> On Tue, 14 Apr 2015, Don Slutz wrote:
>>>>>> On 04/14/15 04:53, Wei Liu wrote:
>>>>>>> Is there a way to know how much more memory each option rom needs? If
>>>>>>> so, you can correctly account for the extra memory you need. This
>>>>>>> would
>>>>>>> be an ideal fix to this problem.
>>>>>>
>>>>>> I do not know of a way to get this info.  It can change based on the
>>>>>> QEMU version.
>>>>>
>>>>> Indeed it would be fragile to rely on a fixed size for each option rom,
>>>>> given that they come out of the QEMU tree and can change at any time.
>>>>
>>>> Only having dipped into this thread so far it seems to me we need some
>>>> way for qemu to communicate the result of its manipulations of maxmem
>>>> into the migration stream explicitly to be picked up by the other end.
>>>
>>> Totally agreed.
>>
>> Xen knows exactly the maxmem setting for the domain, I don't think we
>> need one more notification from QEMU?
>> Libxl/Xen could just write the maxmem value to the migration stream.
> 
> If that is all which is needed and not the delta between the notional
> maxmem which the guest was configured with and what we actually gave it
> due to things such as option ROMs, then sure.
> 

This is what v2 of this patch does.

   -Don Slutz

> Ian.
>