All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2] direct-io: only inc/dec inode->i_dio_count for file systems
Date: Wed, 15 Apr 2015 16:06:49 -0600	[thread overview]
Message-ID: <552EE0F9.40607@fb.com> (raw)
In-Reply-To: <20150415220550.GO889@ZenIV.linux.org.uk>

On 04/15/2015 04:05 PM, Al Viro wrote:
> On Wed, Apr 15, 2015 at 04:01:35PM -0600, Jens Axboe wrote:
>> Hi,
>>
>> A proper patch series posting of the patch to skip inode dio counts
>> where we don't need them. Performance results and general notes in
>> patch #1. We can take this a bit further if we want to push this
>> truncate locking into the caller, but I'd like to keep that as a
>> separate patch series instead.
>>
>> Changes since v2:
>>
>> - Changed flag to DIO_SKIP_DIO_COUNT. Patch 2+3 will use this for
>>    skipping the extra inc/dec for btrfs and ext4, so better rename it
>>    to something that better tells what is happening in the deep mess
>>    that is dio.
>>
>> - Have inode_dio_inc/dec() helpers. Again, this better tells the caller
>>    what is going on.
>
> Please, rebase on vfs.git#for-next; it conflicts (at least) with Omar's
> ->direct_IO() patches, if not with generic_write_checks() ones following
> those.

Sure, I can do that.

-- 
Jens Axboe


      reply	other threads:[~2015-04-15 22:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15 22:01 [PATCH v2] direct-io: only inc/dec inode->i_dio_count for file systems Jens Axboe
2015-04-15 22:01 ` [PATCH 1/3] " Jens Axboe
2015-04-15 22:36   ` Dave Chinner
2015-04-15 22:56     ` Al Viro
2015-04-15 23:05       ` Jens Axboe
2015-04-15 23:30         ` Al Viro
2015-04-15 23:50           ` Jens Axboe
2015-04-15 22:57     ` Jens Axboe
2015-04-15 22:01 ` [PATCH 2/3] btrfs: pass in DIO_SKIP_DIO_COUNT to do_blockdev_direct_IO() Jens Axboe
2015-04-15 22:01 ` [PATCH 3/3] ext4: " Jens Axboe
2015-04-15 22:05 ` [PATCH v2] direct-io: only inc/dec inode->i_dio_count for file systems Al Viro
2015-04-15 22:06   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552EE0F9.40607@fb.com \
    --to=axboe@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.