From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 1/3] direct-io: only inc/dec inode->i_dio_count for file systems Date: Wed, 15 Apr 2015 17:50:15 -0600 Message-ID: <552EF937.6060108@fb.com> References: <1429135298-17153-1-git-send-email-axboe@fb.com> <1429135298-17153-2-git-send-email-axboe@fb.com> <20150415223620.GU13731@dastard> <20150415225625.GR889@ZenIV.linux.org.uk> <552EEECC.90008@fb.com> <20150415233051.GT889@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: Dave Chinner , , , Andrew Morton , Christoph Hellwig , "Theodore Ts'o" , "Elliott, Robert (Server Storage)" To: Al Viro Return-path: In-Reply-To: <20150415233051.GT889@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 04/15/2015 05:30 PM, Al Viro wrote: > On Wed, Apr 15, 2015 at 05:05:48PM -0600, Jens Axboe wrote: >> On 04/15/2015 04:56 PM, Al Viro wrote: >>> On Thu, Apr 16, 2015 at 08:36:20AM +1000, Dave Chinner wrote: >>> >>>> Bikeshedding: I think this would be better suited to inode_dio_begin() >>>> and inode_dio_end() because now we are trying to say "this is where >>>> the DIO starts, and this is where it ends". It's not really >>>> "reference counting" interface, we're trying to annotate the >>>> boundaries of where DIO iis protected against truncate.... >>> >>> *nod* >>> >>> And while we are at, inode_dio_begin() could be static inline just fine. >> >> Done (rename and docbook), and inode_dio_{begin.end}() made static inlines. >> >> v3 against vfs-next attached. > > Applied. Awesome, thanks! -- Jens Axboe