From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junxiao Bi Date: Thu, 16 Apr 2015 13:42:17 +0800 Subject: [Ocfs2-devel] [PATCH 1/1] automated tool detected uninitialized variable use in ocfs2_local_alloc_find_clear_bits In-Reply-To: <1428705866-26954-1-git-send-email-tariq.x.saeed@oracle.com> References: <1428705866-26954-1-git-send-email-tariq.x.saeed@oracle.com> Message-ID: <552F4BB9.9090400@oracle.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com Hi Tariq, This have been fixed by upstream commit 023d4ea358494ccfeb37abfe5b0fd01b45a6051c ("ocfs2: fix possible uninitialized variable access"). Thanks, Junxiao. On 04/11/2015 06:44 AM, Tariq Saeed wrote: > Orabug: 19060842 > > In ocfs2_local_alloc_find_clear_bits(), local int numbits is used > without being initialized in an error path. > > Signed-off-by: Tariq Saeed > --- > fs/ocfs2/localalloc.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c > index 0440134..978a6e0 100644 > --- a/fs/ocfs2/localalloc.c > +++ b/fs/ocfs2/localalloc.c > @@ -847,6 +847,7 @@ static int ocfs2_local_alloc_find_clear_bits(struct ocfs2_super *osb, > > if (!alloc->id1.bitmap1.i_total) { > bitoff = -1; > + numfound = -1; > goto bail; > } > >