From: Leon Alrae <leon.alrae@imgtec.com>
To: Liviu Ionescu <ilg@livius.net>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>,
"christopher.covington@linaro.org"
<christopher.covington@linaro.org>,
Matthew Fortune <Matthew.Fortune@imgtec.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument
Date: Thu, 16 Apr 2015 10:27:54 +0100 [thread overview]
Message-ID: <552F809A.2040308@imgtec.com> (raw)
In-Reply-To: <E55E59D0-C979-4A7A-96C5-2753B8DD9DB8@livius.net>
On 15/04/2015 17:08, Liviu Ionescu wrote:
>
>> On 15 Apr 2015, at 15:49, Leon Alrae <leon.alrae@imgtec.com> wrote:
>>
>> ... If there aren't any objections for the proposed solution, then let's
>> just cook up the patch.
>
> the changes related to moving --semihosting-cmdline to the end of the line are in:
>
> git://git.code.sf.net/p/gnuarmeclipse/qemu gnuarmeclipse-qemu
>
> the gnuarmeclipse-dev branch, commit 8010d2
>
> although I did not group the semihosting related variables in a structure, that code may still be a good starting point (especially since it is already functional in my fork).
>
> I suggest you compare the gnuarmeclipse-dev branch with master and get the semihosting related patches.
>
> if you need any help, please don't hesitate to ask.
>
> alternatively I can create the patch, but the changes must also touch non-arm code, and I have no experience there.
Since the new option and your ARM semi-hosting improvements already work
for you I believe it would be much easier if you sent the patches first
rather than us figuring out the changes from your branch. Then we could
go from there reviewing / refining / testing etc.
Thanks,
Leon
next prev parent reply other threads:[~2015-04-16 9:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 13:18 [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument Leon Alrae
2015-04-01 15:21 ` Liviu Ionescu
2015-04-01 16:12 ` Matthew Fortune
2015-04-02 7:56 ` Leon Alrae
2015-04-02 8:29 ` Liviu Ionescu
2015-04-02 9:14 ` Leon Alrae
2015-04-02 10:36 ` Leon Alrae
2015-04-02 12:36 ` Liviu Ionescu
2015-04-02 14:27 ` Matthew Fortune
2015-04-02 16:47 ` Liviu Ionescu
2015-04-03 15:33 ` Liviu Ionescu
2015-04-08 16:20 ` Leon Alrae
2015-04-14 17:42 ` Liviu Ionescu
2015-04-15 9:09 ` Liviu Ionescu
2015-04-15 11:53 ` Leon Alrae
2015-04-15 12:02 ` Matthew Fortune
2015-04-15 12:06 ` Liviu Ionescu
2015-04-15 12:49 ` Leon Alrae
2015-04-15 16:08 ` Liviu Ionescu
2015-04-16 9:27 ` Leon Alrae [this message]
2015-04-17 17:45 ` Liviu Ionescu
2015-04-16 14:22 ` Peter Maydell
2015-04-21 13:34 ` Leon Alrae
2015-04-21 15:14 ` Liviu Ionescu
2015-04-21 15:55 ` Peter Maydell
2015-04-21 16:21 ` Liviu Ionescu
2015-04-21 16:23 ` Peter Maydell
2015-04-21 16:51 ` Liviu Ionescu
2015-04-21 17:50 ` Peter Maydell
2015-04-21 16:48 ` Eric Blake
2015-04-21 16:54 ` Peter Maydell
2015-04-21 17:22 ` Eric Blake
2015-04-21 17:49 ` Liviu Ionescu
2015-04-21 18:08 ` Liviu Ionescu
2015-04-23 11:55 ` Leon Alrae
2015-04-23 12:07 ` Liviu Ionescu
2015-04-01 15:45 ` Christopher Covington
2015-04-01 16:24 ` Liviu Ionescu
2015-04-04 15:20 ` Liviu Ionescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552F809A.2040308@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=Matthew.Fortune@imgtec.com \
--cc=christopher.covington@linaro.org \
--cc=ilg@livius.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.