From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matan Barak Subject: Re: [PATCH v3 for-next 01/33] IB/core: Add RoCE GID cache Date: Thu, 16 Apr 2015 13:42:04 +0300 Message-ID: <552F91FC.4090801@mellanox.com> References: <1427318422-12004-1-git-send-email-somnath.kotur@emulex.com> <44ab0dce-c7c9-400b-af24-10b8981358a7@CMEXHTCAS2.ad.emulex.com> <1828884A29C6694DAF28B7E6B8A82373A8FBE792@ORSMSX109.amr.corp.intel.com> <7F44EA5110810A40B7DAFB605C41975D58F98121@CMEXMB1.ad.emulex.com> <1828884A29C6694DAF28B7E6B8A82373A8FC0C00@ORSMSX109.amr.corp.intel.com> <552CDEA5.6020709@mellanox.com> <1828884A29C6694DAF28B7E6B8A82373A8FC11F3@ORSMSX109.amr.corp.intel.com> <7F44EA5110810A40B7DAFB605C41975D58FA0B05@CMEXMB1.ad.emulex.com> <1828884A29C6694DAF28B7E6B8A82373A8FC19D9@ORSMSX109.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Suri Shelvapille , "Hefty, Sean" , Somnath Kotur , "roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org AFAIK, RoCE v2 is the known and official name. Why would we like to come up with a customized name? These are indeed two different protocols, thus the comparison to DHCP assigned addresses and static addresses is (to say the least) a bit off. Even when comparing IPv4 and IPv6, the most significant user change is the sockaddr_in and sockaddr_in6 addresses. IMHO, since the GID format is identical, the changes could be encoded in a gid_type argument. The gid_type is an inherent part of the address, making identical gids with different gid_types as two different addresses, as expected. On 4/15/2015 7:21 PM, Suri Shelvapille wrote: > IMHO, it would be good to have a physical layer representation in the naming convention. > > -----Original Message----- > From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Hefty, Sean > Sent: Wednesday, April 15, 2015 12:08 PM > To: Somnath Kotur; Matan Barak; roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org > Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Subject: RE: [PATCH v3 for-next 01/33] IB/core: Add RoCE GID cache > >> It does not break every app, the choice of which GID type to use is >> made by the RDMA-CM based on network topology hint obtained from the IP stack. >> Please refer to patch 15/33: IB/Core: Changes to the IB Core >> infrastructure for RoCEv2 support. >> Of course, if the user does not want to go with this choice made by >> the RDMA-CM, then there is the option of overriding it using the >> configfs patch (PATCH 14/33) Hope that clarifies? > > RoCE v2 is really Infiniband over UDP over IP. Why don't we just call it IBoUDP like it is? > > IBoUDP changes the Ethertype, replaces the network header, adds a new transport protocol header, and layers IB over that. This change should be exposed properly and not as just a new GID type. > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html > > This correspondence, and any attachments or files transmitted with this correspondence, contains information which may be confidential and privileged and is intended solely for the use of the addressee. Unless you are the addressee or are authorized to receive messages for the addressee, you may not use, copy, disseminate, or disclose this correspondence or any information contained in this correspondence to any third party. If you have received this correspondence in error, please notify the sender immediately and delete this correspondence and any attachments or files transmitted with this correspondence from your system, and destroy any and all copies thereof, electronic or otherwise. Your cooperation and understanding are greatly appreciated. > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html