From: Stephen Smalley <sds@tycho.nsa.gov>
To: Nick Kralevich <nnk@google.com>, selinux@tycho.nsa.gov
Subject: Re: [PATCH] Add empty top level Android.mk / CleanSpec.mk files
Date: Thu, 16 Apr 2015 07:58:08 -0400 [thread overview]
Message-ID: <552FA3D0.7080606@tycho.nsa.gov> (raw)
In-Reply-To: <1429135642-25619-1-git-send-email-nnk@google.com>
On 04/15/2015 06:07 PM, Nick Kralevich wrote:
> Needed to allow Android to keep building with a copy of the SELinux
> source code checked into external/selinux
>
> Bug: 19963152
> Change-Id: I4e192bb6ca5d185e11540aca7253e729d92a00c1
Thanks, applied. I assume at some point you'll switch over to using the
external/selinux/{libsepol,checkpolicy,secilc} and drop
external/{libsepol,checkpolicy}, but retain external/libselinux since it
is a fork and differs substantially as described in its README.android
file. I suppose someone could try to upstream all the changes, some
under conditional guards for ANDROID, but it wouldn't be trivial; I took
a hacksaw to libselinux originally for Android.
> ---
> Android.mk | 2 ++
> CleanSpec.mk | 2 ++
> 2 files changed, 4 insertions(+)
> create mode 100644 Android.mk
> create mode 100644 CleanSpec.mk
>
> diff --git a/Android.mk b/Android.mk
> new file mode 100644
> index 0000000..02f35a9
> --- /dev/null
> +++ b/Android.mk
> @@ -0,0 +1,2 @@
> +# This empty Android.mk file will prevent the build system
> +# from building anything below this point.
> diff --git a/CleanSpec.mk b/CleanSpec.mk
> new file mode 100644
> index 0000000..1ac5a62
> --- /dev/null
> +++ b/CleanSpec.mk
> @@ -0,0 +1,2 @@
> +# This empty CleanSpec.mk file will prevent the build system
> +# from descending into subdirs.
>
next prev parent reply other threads:[~2015-04-16 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 22:07 [PATCH] Add empty top level Android.mk / CleanSpec.mk files Nick Kralevich
2015-04-15 22:22 ` Jeffrey Vander Stoep
2015-04-16 11:58 ` Stephen Smalley [this message]
2015-04-16 14:01 ` Nick Kralevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552FA3D0.7080606@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=nnk@google.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.