From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v5 p2 12/19] xen/passthrough: Extend XEN_DOMCTL_*assign_device to support DT device Date: Thu, 16 Apr 2015 16:21:53 +0100 Message-ID: <552FD391.7060703@citrix.com> References: <1428592185-18581-1-git-send-email-julien.grall@citrix.com> <1428592185-18581-13-git-send-email-julien.grall@citrix.com> <1429197092.25195.151.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Yilcq-0006s4-9M for xen-devel@lists.xenproject.org; Thu, 16 Apr 2015 15:22:44 +0000 In-Reply-To: <1429197092.25195.151.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Wei Liu , tim@xen.org, Julien Grall , Ian Jackson , stefano.stabellini@citrix.com, Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 16/04/2015 16:11, Ian Campbell wrote: > On Thu, 2015-04-09 at 16:09 +0100, Julien Grall wrote: >> From: Julien Grall >> >> A device node is described by a path. It will be used to retrieved the > > "retrieve" > >> node in the device tree and assign the related device to the domain. >> >> Only non-PCI protected by an IOMMU can be assigned to a guest. > > I think a word is missing between PCI and protected, perhaps "devices"? Yes. > >> Also document the behavior of XEN_DOMCTL_deassign_device in the public >> headers which differ between non-PCI and PCI. >> >> Signed-off-by: Julien Grall >> Acked-by: Jan Beulich >> Cc: Ian Jackson >> Cc: Wei Liu > > With the above fixed: > > Acked-by: Ian Campbell Thanks, -- Julien Grall