From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linda Subject: Re: [PATCH v7] libxl: provide libxl_bitmap_{or,and} Date: Thu, 16 Apr 2015 10:49:17 -0600 Message-ID: <552FE80D.9000908@jma3.com> References: <1429117327-6845-1-git-send-email-lindaj@jma3.com> <1429194854.25195.134.camel@citrix.com> <552FC9F4.80207@jma3.com> <20150416144557.GF13154@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YinL1-0000PP-Qx for xen-devel@lists.xenproject.org; Thu, 16 Apr 2015 17:12:27 +0000 In-Reply-To: <20150416144557.GF13154@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Ian Campbell , stefano.stabellini@eu.citrix.com, lars.kurth.xen@gmail.com, julien.grall@citrix.com, ian.jackson@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 4/16/2015 8:45 AM, Wei Liu wrote: > On Thu, Apr 16, 2015 at 08:40:52AM -0600, Linda wrote: >> On 4/16/2015 8:34 AM, Ian Campbell wrote: >>> On Wed, 2015-04-15 at 11:02 -0600, Linda Jacobson wrote: >>>> New functions to provide logical and and or of two bitmaps functions can be >>>> used in vNUMA configuration check function. >>> I don't think that really justifies adding them, since we aren't >>> actually using them for that now, how about: >>> >>> New functions to provide logical and and or of two bitmaps. >>> These are generically useful utility functions added to the >>> public API for the benefit of libxl's users. >>> In the future they may also be useful internally, e.g. in the >>> vNUMA configuration check function. >>> >>> If you are happy with that, and there's no other reason to resend, then >>> I can switch in that text as I commit. >> I'm fine with this. If Wei and Julien are, please go ahead. > Julien is away now. I'm of course fine with this -- it's your > contribution after all, you have the final say. :-) Then, Ian, please, go ahead. > > And congratulations to you for getting first patch accepted! Why, thank you. Linda > > Wei. > >>>> Signed-off-by: Linda Jacobson >>>> >>>> --- >>>> >>>> v.1 The new functions were added. >>>> v.2 The comments and format were corrected. >>>> v.3 The bitmap functions were rewritten to manipulate bytes not bits. >>>> v.4 Several non-modified parameters, and local variables were changed to const >>>> Also the code formatting was fixed. >>>> v.5 The commit subject line now has versions and is simpler. >>>> v.6 All descriptions in the commit history are now complete sentences. >>>> Extraneous blank lines are gone. >>>> v.7 Added LIBXL_BIT_HAVE_AND_OR to libxl.h; deleted extraneous comment in >>>> libxl_utils.h; and updated the commit log to include the uses for these >>>> functions >>>> --- >>>> tools/libxl/libxl.h | 9 ++++++ >>>> tools/libxl/libxl_utils.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++ >>>> tools/libxl/libxl_utils.h | 6 ++++ >>>> 3 files changed, 85 insertions(+) >>>> >>>> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h >>>> index 5eec092..1fb9549 100644 >>>> --- a/tools/libxl/libxl.h >>>> +++ b/tools/libxl/libxl.h >>>> @@ -84,6 +84,15 @@ >>>> #define LIBXL_HAVE_CPUPOOL_QUALIFIER_TO_CPUPOOLID 1 >>>> /* >>>> + * >>>> + * LIBXL_HAVE_BITMAP_AND_OR >>>> + * >>>> + * If this is defined, libxl has two libarary functions, libxl_bitmap_and >>> "library". >>> >>> (again, can fix on commit) >> Thanks for catching the typo. >> >> Linda Jacobson >>> Other than those: >>> Acked-by: Ian Campbell >>> >>> >>>