From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>,
Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH 1/1] x86/hvm: prevent hvm_free_ioreq_gmfn() clobber of arbitrary memory
Date: Thu, 16 Apr 2015 19:44:57 +0100 [thread overview]
Message-ID: <55300329.40807@citrix.com> (raw)
In-Reply-To: <20150416163700.GK13441@deinos.phlegethon.org>
On 16/04/15 17:37, Tim Deegan wrote:
> At 12:32 +0100 on 16 Apr (1429187564), Jan Beulich wrote:
>>>>> On 16.04.15 at 12:53, <tim@xen.org> wrote:
>>> I would be inclined to use a bigger hammer here. IMO refactoring like
>>> this makes it easier to reason about (compile tested only):
>> This looks like a pretty nice cleanup; I particularly like the 4 labels
>> going away.
> OK, here it is as a proper patch. I still haven't tested it -- indeed
> I'm not sure how to test multiple ioreq clients. Any suggestions?
>
> From 67957b954f2b8d58b635a8e5fdc818154ec9e4ff Mon Sep 17 00:00:00 2001
> From: Tim Deegan <tim@xen.org>
> Date: Thu, 16 Apr 2015 17:34:24 +0100
> Subject: [PATCH] x86/hvm: refactor code that allocates ioreq gfns.
>
> It was confusing GCC's uninitialized-variable detection.
>
> Signed-off-by: Tim Deegan <tim@xen.org>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2015-04-16 18:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 16:01 [PATCH 1/1] x86/hvm: prevent hvm_free_ioreq_gmfn() clobber of arbitrary memory Don Slutz
2015-04-14 11:47 ` Jan Beulich
2015-04-14 13:17 ` Andrew Cooper
2015-04-14 22:54 ` Don Slutz
2015-04-16 10:53 ` Tim Deegan
2015-04-16 11:32 ` Jan Beulich
2015-04-16 16:37 ` Tim Deegan
2015-04-16 18:44 ` Andrew Cooper [this message]
2015-04-17 7:45 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2015-04-23 13:25 Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55300329.40807@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=dslutz@verizon.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.