From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Guenter Roeck <linux@roeck-us.net>,
Florian Fainelli <f.fainelli@gmail.com>,
kernel@savoirfairelinux.com
Subject: Re: [PATCH 1/2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max
Date: Thu, 16 Apr 2015 21:55:49 +0300 [thread overview]
Message-ID: <553005B5.9000101@cogentembedded.com> (raw)
In-Reply-To: <1429209499-2447-1-git-send-email-vivien.didelot@savoirfairelinux.com>
Hello.
On 04/16/2015 09:38 PM, Vivien Didelot wrote:
> Since commit da4759c, sysfs will only use the permissions returned by
Please also specify that commit's summary line in parens.
> is_visible, instead of OR'ing them with the default file mode.
> This allows us to declare temp1_max with the DEVICE_ATTR_RW macro and
> just return the desired permissions for the hwmon sysfs attributes in
> dsa_hwmon_attrs_visible.
> Also, allow temp1_max to be write-only if set_temp_limit is provided,
> but not get_temp_limit.
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
WBR, Sergei
next prev parent reply other threads:[~2015-04-16 18:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 18:38 [PATCH 1/2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max Vivien Didelot
2015-04-16 18:38 ` [PATCH 2/2] net: dsa: register hwmon for any provided function Vivien Didelot
2015-04-16 21:26 ` Guenter Roeck
2015-04-16 22:05 ` Vivien Didelot
2015-04-17 2:17 ` Guenter Roeck
2015-04-17 14:45 ` Vivien Didelot
2015-04-16 18:55 ` Sergei Shtylyov [this message]
2015-04-16 19:13 ` [PATCH 1/2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max Vivien Didelot
2015-04-16 21:24 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553005B5.9000101@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.