From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH v2 0/3] libxl: fd events: Recheck with poll Date: Thu, 16 Apr 2015 15:19:27 -0600 Message-ID: <5530275F.4040902@suse.com> References: <[PATCH v2 0/3] libxl: fd events: Recheck fd events> <1429208608-6185-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1429208608-6185-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xensource.com Cc: Ian Campbell List-Id: xen-devel@lists.xenproject.org On 04/16/2015 12:23 PM, Ian Jackson wrote: > Ian: >>> Jim: >>> I too saw this bug just before Konrad's report, but the patches >>> don't seem to\ >>> help. Running a script that continually saves and restores domains will >>> eventually lock libvirtd with essentially the same traces reported by Konrad >> I'm a total idiot. I do the recheck but I don't pay any attention to >> the result. > Sorry to waste your time. Now fixed, I hope. > >> Having slept on this I wonder if it might be better to always do this >> recheck in the event core before making the fd callback. The current >> semantics are a bit of a gotcha. > And this, done. These 3 patches are entirely different to the last > attempt. > > Again, compiled but not tested. I tested the v2 patches and no longer see the problem. I didn't review them closely, so ATM can only add Tested-by: Jim Fehlig Thanks Ian! Regards, Jim