Re: [v2 05/11] vmx: add new data structure member to support PML

[Kai Huang <kai.huang@linux.intel.com>]

On 04/16/2015 11:33 PM, Jan Beulich wrote:
>>>> On 15.04.15 at 09:03, <kai.huang@linux.intel.com> wrote:
>> --- a/xen/include/asm-x86/hvm/vmx/vmcs.h
>> +++ b/xen/include/asm-x86/hvm/vmx/vmcs.h
>> @@ -70,8 +70,12 @@ struct ept_data {
>>       cpumask_var_t synced_mask;
>>   };
>>   
>> +#define _VMX_DOMAIN_PML_ENABLED    0
>> +#define VMX_DOMAIN_PML_ENABLED     (1ul << _VMX_DOMAIN_PML_ENABLED)
>>   struct vmx_domain {
>>       unsigned long apic_access_mfn;
>> +    /* VMX_DOMAIN_* */
>> +    unsigned long status;
> Please us "unsigned int" until 32 bits wouldn't suffice anymore. This
> will (on the average) produce slightly smaller code.
Sure.

Thanks,
-Kai
>
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel